-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README-ko.md file #4781
Update README-ko.md file #4781
Conversation
Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com>
Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check the reviews below? rest looks good to me :)
Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It would be nice to have a Korean glossary. (e.g., Kubernetes Korean glossary)
@namkyu1999 are we good to merge this PR? |
Yes, looks good to me |
* Update README-ko.md file Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> * Update README-ko.md Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> * Update README-ko.md file Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> --------- Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
* Update README-ko.md file Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> * Update README-ko.md Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> * Update README-ko.md file Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> --------- Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
* Update README-ko.md file Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> * Update README-ko.md Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> * Update README-ko.md file Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> --------- Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com> Signed-off-by: imsuhyen <ishyenn@gmail.com> Signed-off-by: imsuhyen <suhyenim.kor@gmail.com> Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com> Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Proposed changes
Translate README.md file into Korean.
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: