Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README-ko.md file #4781

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

suhyenim
Copy link
Contributor

@suhyenim suhyenim commented Jul 21, 2024

Proposed changes

Translate README.md file into Korean.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>
Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the reviews below? rest looks good to me :)

translations/README-ko.md Outdated Show resolved Hide resolved
translations/README-ko.md Outdated Show resolved Hide resolved
translations/README-ko.md Outdated Show resolved Hide resolved
translations/README-ko.md Outdated Show resolved Hide resolved
Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It would be nice to have a Korean glossary. (e.g., Kubernetes Korean glossary)

@neelanjan00
Copy link
Member

@namkyu1999 are we good to merge this PR?

@namkyu1999
Copy link
Member

@namkyu1999 are we good to merge this PR?

Yes, looks good to me

@Saranya-jena Saranya-jena merged commit 1d44031 into litmuschaos:master Aug 9, 2024
17 checks passed
kwx4957 pushed a commit to kwx4957/litmus that referenced this pull request Sep 1, 2024
* Update README-ko.md file

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>

* Update README-ko.md

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>

* Update README-ko.md file

Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>

---------

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>
Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* Update README-ko.md file

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>

* Update README-ko.md

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>

* Update README-ko.md file

Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>

---------

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>
Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
* Update README-ko.md file

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>

* Update README-ko.md

Signed-off-by:  Suhyen Im <suhyenim.kor@gmail.com>

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>

* Update README-ko.md file

Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>

---------

Signed-off-by: Suhyen Im <suhyenim.kor@gmail.com>
Signed-off-by: imsuhyen <ishyenn@gmail.com>
Signed-off-by: imsuhyen <suhyenim.kor@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants