Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image links in README #4811

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Aug 6, 2024

Proposed changes

https://landscape.cncf.io/images/left-logo.svg is bad link right now. And cncf/artwork renamed the master branch to main.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Special notes for your reviewer:

cc. @namkyu1999

Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@Saranya-jena
Copy link
Contributor

Hi @jongwooo can you resolve the conflicts?

@jongwooo
Copy link
Contributor Author

@Saranya-jena Sure thing:)

@jongwooo jongwooo force-pushed the fix/fix-image-links branch 2 times, most recently from 6c6f135 to 29dca0a Compare August 14, 2024 09:55
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
@Saranya-jena Saranya-jena merged commit a325a0e into litmuschaos:master Aug 14, 2024
17 checks passed
@jongwooo jongwooo deleted the fix/fix-image-links branch August 14, 2024 10:17
kwx4957 pushed a commit to kwx4957/litmus that referenced this pull request Sep 1, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
andoriyaprashant pushed a commit to andoriyaprashant/litmus that referenced this pull request Sep 7, 2024
Signed-off-by: Jongwoo Han <jongwooo.han@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants