litmsuctl create scenario command independent of install-chaos-experiments step #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamnicoj
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
Saranya-jena
approved these changes
Dec 9, 2022
|
🚀 🚀 |
SarthakJain26
approved these changes
Dec 9, 2022
Saranya-jena
reviewed
Dec 9, 2022
iamnicoj
force-pushed
the
master
branch
3 times, most recently
from
7510c82
to
6cb2747
Compare
Signed-off-by: Nico J <nicolasj@microsoft.com> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Co-authored-by: Saranya Jena <saranya.jena@harness.io> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com> Signed-off-by: iamnicoj <nicolasj@outlook.com> Signed-off-by: Nico J <nicolasj@microsoft.com>
Signed-off-by: Nico J <nicolasj@microsoft.com>
Jonsy13
approved these changes
Dec 12, 2022
|
Thanks @iamnicoj for this great enhancement & contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #113 and aligns the
litmusctl create chaos-scenariowith the ChaosCenter functionality around checking for experimentweightsand defining default values even when there are no experiments present ( as may be the case when using templated workflows).