Add .exe extension to binaries on Windows #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebcay
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
Signed-off-by: Caleb Xu <calebcenter@live.com>
alebcay
force-pushed
the
litmusctl-windows-exe
branch
from
ea59a76
to
a3822e3
Compare
SarthakJain26
approved these changes
Sep 12, 2022
Saranya-jena
approved these changes
Sep 12, 2022
Jonsy13
approved these changes
Sep 13, 2022
vanshBhatia-A4k9
approved these changes
Sep 13, 2022
|
Thanks @alebcay for the contribution!! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaries available for download for Windows currently ship the binary as
litmusctl(with no extension). While this is expected on Linux/macOS (where executables have no extension), it seems that Windows has trouble running/recognizing executable files that have no extension. Windows users currently need to rename the file manually to be able to execute it.This PR modifies the build script to add
.exeextension for Windows build artifacts where it is expected.