Make sure we do not create an unaligned slice #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks for the patch. Maybe an assert would be better than the comment? We can spare the cycles here. |
Sure, done. |
|
Thanks again 👍. @llogiq Could we get a patch release for this? This shouldn't have actually caused any bad codegen but it'll help around rust-lang/rust#52972. |
|
I just published 0.3.2. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 16, 2018
stabilize slice_align_to This is very hard to implement correctly, and leads to [serious bugs](llogiq/bytecount#42) when done incorrectly. Moreover, this is needed to be able to run code that opportunistically exploits alignment on miri. So code using `align_to`/`align_to_mut` gets the benefit of a well-tested implementation *and* of being able to run in miri to test for (some kinds of) UB. This PR also clarifies the guarantee wrt. the middle part being as long as possible. Should the docs say under which circumstances the middle part could be shorter? Currently, that can only happen when running in miri.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…r=alexcrichton Add a debug_assert to Vec::set_len Following the precedent of rust-lang#52972, which found llogiq/bytecount#42. (This may well make a test fail; let's see what Travis says.)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 14, 2019
…r=alexcrichton Add a debug_assert to Vec::set_len Following the precedent of rust-lang#52972, which found llogiq/bytecount#42. (This may well make a test fail; let's see what Travis says.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in rust-lang/rust#52972:
References have to be always aligned. This includes
&[T], and it includes the case where the slice is empty.chunk_alignwas producing an unalignedmidpart when thecmp::min(..., d2)picked the RHS.So I pulled the conditional out of
cmp::min, returning early if the slice is so short that the aligned beginning is beyond the end of the slice.