[SandboxIR] Implement AtomicCmpXchgInst #102710
Conversation
vporpo
requested review from
slackito,
echristo,
alinas,
tschuett,
aeubanks and
Sterling-Augustine
vporpo
force-pushed
the
SBVec
branch
2 times, most recently
from
a50c57e
to
b9f896c
Compare
| /// so release semantics cannot be provided. So this function drops explicit | ||
| /// Release requests from the AtomicOrdering. A SequentiallyConsistent | ||
| /// operation would remain SequentiallyConsistent. | ||
| static AtomicOrdering |
There was a problem hiding this comment.
we don't need this here? this is a copy of the LLVM version that users can just call directly instead since it doesn't use any Value
There was a problem hiding this comment.
It's not strictly needed, the user could just call the LLVM version. But I feel we should be providing these functions for completeness, so that the user won't have to look for them in the LLVM IR classes.
There was a problem hiding this comment.
this is so rarely used and so specific that I doubt anybody will be using SandboxIR and will be wanting getStrongestFailureOrdering as well. IMO we should only add the APIs people will likely use, not obscure ones, especially if those APIs don't require an llvm::Value. but happy to be overruled if people think otherwise
This patch implements sandboxir::AtomicCmpXchgInst which mirrors llvm::AtomiCmpXchgInst.
This patch implements sandboxir::AtomicCmpXchgInst which mirrors llvm::AtomiCmpXchgInst.
This patch implements sandboxir::AtomicCmpXchgInst which mirrors llvm::AtomiCmpXchgInst.