Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][LV] VPlan-based cost model #67647

Closed
wants to merge 3 commits into from
Closed

Commits on Aug 16, 2023

  1. [VPlan] Compute costs for plans directly after construction.

    Directly compute the cost of a VPlan after construction and track it
    together with a plan. This allows moving selecting the best VF to the
    planner. This seems to be a good fit anyways, and removes code from the
    cost-model that is not directly related to assigning costs to a specific
    plan/VF. Later this can be swapped out with computing the cost for a
    plan directly.
    
    This may help to simplify D142015.
    
    Differential Revision: https://reviews.llvm.org/D143938
    fhahn authored and arcbbb committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a0c0d43 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. [RFC][LV] VPlan-based cost model

    This patch follows D89322 to add an initial skeleton of vplan-based cost model.
    
    This difference is that instead of incorporating a cost() interface to VPRecipes,
    all cost implementations are put together in VPlanCostModel.
    
    This allows VPlanCostModel to concentrate on assigning costs to vplan,
    thus seprating the cost model code from the vplan IR, similar to LLVM IR cost
    modeling.
    
    During the transition, it will still use the legacy model to obtain cost until
    all cost calculation for recipes are implemented.
    
    Please let me know if you agree with the main idea of this patch.
    If there is a general consensus, I'll proceed to implement the cost for the
    other recipes for review.
    
    Differential Revision: https://reviews.llvm.org/D158716
    
    - Address comments
    - Move VPCM object outside of the loop
    - Add getElementType() and getReturnElementType()
    arcbbb committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    edc764b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Fix comments in c++ header

    arcbbb committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    650d0ec View commit details
    Browse the repository at this point in the history