Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VPlan] Add initial anlysis to infer scalar type of VPValues. #69013

Merged
merged 13 commits into from
Oct 27, 2023
Merged

[VPlan] Add initial anlysis to infer scalar type of VPValues. #69013

merged 13 commits into from
Oct 27, 2023

Commits on Oct 10, 2023

  1. [VPlan] Add initial anlysis to infer scalar type of VPValues. 

    This patch adds initial type inferrence for VPValues. It infers the
scalar type of a VPValue, by bottom-up traversing through defining recipes until
root nodes with known types are reached (e.g. live-ins or memory
recipes). The types are then propagated top down through operations.

This is intended as building block for a VPlan-based cost model, which
will need access to type information for VPValues/recipes.

Initial testing is done by asserting the inferred type matches the type
of the result value generated for a widen recipe.
    @fhahn
    fhahn committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    22b23c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Remove Store case for VPReplicateRecipe, as it is dead code.

    @fhahn
    fhahn committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    30a8968 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Update llvm/lib/Transforms/Vectorize/VPlanAnalysis.h 

    Co-authored-by: ayalz <47719489+ayalz@users.noreply.github.com>
    @fhahn @ayalz
    fhahn and ayalz authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    58b145e View commit details
    Browse the repository at this point in the history

  2. Update llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp 

    Co-authored-by: ayalz <47719489+ayalz@users.noreply.github.com>
    @fhahn @ayalz
    fhahn and ayalz authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d89b7d8 View commit details
    Browse the repository at this point in the history

  3. Address comments

    @fhahn
    fhahn committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    4ed3b6d View commit details
    Browse the repository at this point in the history

  4. Fix formatting.

    @fhahn
    fhahn committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    529805c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Address comments

    @fhahn
    fhahn committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    a75c562 View commit details
    Browse the repository at this point in the history

  2. Add assert to rule out stores in inferScalarType

    @fhahn
    fhahn committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    1483f63 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Add a few more missed cases, verify types for VPReplicateRecipe codegen.

    @fhahn
    fhahn committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    79bcce9 View commit details
    Browse the repository at this point in the history

  2. Use TypeSwitch.

    @fhahn
    fhahn committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    532d75e View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Apply suggestions from code review 

    Co-authored-by: ayalz <47719489+ayalz@users.noreply.github.com>
    @fhahn @ayalz
    fhahn and ayalz authored Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5bbd764 View commit details
    Browse the repository at this point in the history

  2. Address latest comments, thanks!

    @fhahn
    fhahn committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    74525ad View commit details
    Browse the repository at this point in the history

  3. Address latest comments.

    @fhahn
    fhahn committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    722cc3d View commit details
    Browse the repository at this point in the history