Commits on Jun 24, 2024

1. [lldb/DWARF] Remove parsing recursion when searching for definition DIEs …

   If ParseStructureLikeDIE (or ParseEnum) encountered a declaration DIE,
   it would call FindDefinitionTypeForDIE. This returned a fully formed
   type, which it achieved by recursing back into ParseStructureLikeDIE
   with the definition DIE.
   
   This obscured the control flow and caused us to repeat some work (e.g.
   the UniqueDWARFASTTypeMap lookup), but it mostly worked until we tried
   to delay the definition search in llvm#90663. After this patch, the two
   ParseStructureLikeDIE calls were no longer recursive, but rather
   the second call happened as a part of the CompleteType() call. This
   opened the door to inconsistencies, as the second ParseStructureLikeDIE
   call was not aware it was called to process a definition die for an
   existing type.
   
   To make that possible, this patch removes the recusive type resolution
   from this function, and leaves just the "find definition die"
   functionality. After finding the definition DIE, we just go back to the
   original ParseStructureLikeDIE call, and have it finish the parsing
   process with the new DIE.
   
   While this patch is motivated by the work on delaying the definition
   searching, I believe it is also useful on its own.

   

   labath committed Jun 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 52db8db
   • Browse repository at this point

   Copy the full SHA

   52db8db View commit details

   Browse the repository at this point in the history

2. update dietotype

   

   labath committed Jun 24, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 683d881
   • Browse repository at this point

   Copy the full SHA

   683d881 View commit details

   Browse the repository at this point in the history