Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: initialize a few more MinimizerResult attributes #771

Merged

Conversation

reneeotten
Copy link
Contributor

Description

This PR initializes a few more attributes of the MinimizerResult class, as discussed on the mailinglist.

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.9.9 (main, Nov 16 2021, 07:21:43)
[Clang 11.0.3 (clang-1103.0.32.62)]

lmfit: 1.0.3.post10+ga7298d4, scipy: 1.7.3, numpy: 1.21.4, asteval: 0.9.25, uncertainties: 3.1.6

Verification

Have you

  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?

@reneeotten reneeotten force-pushed the initialize-ModelResult-attributes branch from a7298d4 to 8464709 Compare December 7, 2021 18:30
@reneeotten reneeotten changed the title ENH: initialize a few more ModelResult attributes ENH: initialize a few more MinimizerResult attributes Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #771 (d27a5aa) into master (275d830) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d27a5aa differs from pull request most recent head 8464709. Consider uploading reports for the commit 8464709 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files          10       10           
  Lines        3411     3413    +2     
=======================================
+ Hits         3198     3200    +2     
  Misses        213      213           
Impacted Files Coverage Δ
lmfit/minimizer.py 90.80% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275d830...8464709. Read the comment docs.

@newville
Copy link
Member

newville commented Dec 7, 2021

@reneeotten Thanks - happy to merge this when you say it is ready.

@reneeotten reneeotten merged commit 36d1aa0 into lmfit:master Dec 7, 2021
@reneeotten reneeotten deleted the initialize-ModelResult-attributes branch December 7, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants