fix 'linear' mode for RectangleModel (lmfit#815) #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arunpersaud Thanks - I think this is good. I would intend to merge in a couple of days unless there are any other concerns or comments. |
|
@arunpersaud looks good to me, thanks! If you'd be willing to amend your commit message and add "Closes: #815" as the last line of the body that would be great as it will close the Issue automatically when the PR gets merged (then please remove the reference to the issue from the commit summary). |
Fix the linear mode for RectangleModel. Also update the documentation
and update the tests.
Tests:
* Using numpy functions now allows lineshape.rectangle to handle
single floats, so the tests needed to be updated
* added tests for step and rectangle to make sure we get A/2 at
mu1 (and mu2)
Docs:
* update to reflect code and make brackets in LaTeX equations a bit nicer
Closes: lmfit#815
arunpersaud
force-pushed
the
fix_rectanglemodel_linear
branch
from
125c830
to
88b7b30
Compare
|
just updated the commit message. |
|
@reneeotten OK to (squash and) merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the linear mode for RectangleModel. Also update the documentation and update the tests. (#815)
Tests:
Docs:
Type of Changes
Tested on
Python: 3.10.8 (main, Oct 13 2022, 09:48:40) [Clang 14.0.0 (clang-1400.0.29.102)]
lmfit: 1.0.0.post473+g125c830.d20221024, scipy: 1.9.3, numpy: 1.23.4, asteval: 0.9.27, uncertainties: 3.1.7
Verification
Have you