Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make params prefix #895

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Make params prefix #895

merged 2 commits into from
Jun 24, 2023

Conversation

newville
Copy link
Member

This should fix #893

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.10.10 | packaged by conda-forge | (main, Mar 24 2023, 20:17:34) [Clang 14.0.6 ]
lmfit: 1.2.1.post5+g980a5d1, scipy: 1.10.1, numpy: 1.24.3, asteval: 0.9.30, uncertainties: 3.1.7

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #895 (aaf908e) into master (980a5d1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          10       10           
  Lines        3615     3615           
=======================================
  Hits         3382     3382           
  Misses        233      233           
Impacted Files Coverage Δ
lmfit/model.py 91.08% <100.00%> (ø)

@newville
Copy link
Member Author

@reneeotten We're kind of stacking up a lot of PRs, and I am reluctant to let these linger too long and have PRs get out-of-date This one seems the least in need of discussion to me, so I'm going to merge it.

@newville newville merged commit 1ab95ae into master Jun 24, 2023
15 checks passed
@newville newville deleted the make_params_prefix branch July 6, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model.make_params() sometimes ignores set a parameter with a prefix
1 participant