Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saveload custom func #934

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Saveload custom func #934

merged 4 commits into from
Dec 30, 2023

Conversation

newville
Copy link
Member

This fixes some of the save/load issues lingering after #932, and fixes some test deprecatiosn

Here we add a "version 2" of the JSON encoding of ModelResult, now relying on Parameter.dumps().
Tests are not altered, and should still all pass.

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on
Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@newville newville merged commit 2f635c1 into master Dec 30, 2023
12 of 14 checks passed
@newville newville deleted the saveload_custom_func branch April 4, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant