Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a copy of sys.module when iterating over #949

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

jcjaskula-aws
Copy link
Contributor

Description

Copy sys.module before iterating over it.

Closes #948

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0 (clang-1500.3.9.4)]

lmfit: 1.3.0, scipy: 1.11.4, numpy: 1.26.3,asteval: 0.9.32, uncertainties: 3.1.6###### Link(s)

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

@jcjaskula-aws jcjaskula-aws changed the title Copy sys.module Use a copy of sys.module when iterating over Apr 6, 2024
@newville
Copy link
Member

newville commented Apr 7, 2024

@jcjaskula-aws Thanks!

@newville newville merged commit cf2626b into lmfit:master Apr 7, 2024
12 checks passed
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/copy_sys_module branch April 10, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sys.module needs to be copied before being iterated over
2 participants