Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recommended error level #317

Merged

Conversation

GradedJestRisk
Copy link
Contributor

🦄 Problem

recommended rules set include warning and error level rules.
Some team may rely on rules to prevent unwanted behavior, like the one addressed by mocha/no-exclusive-tests.
To make it work in CI, and not to rely on developer's local hooks, the default error level should be elevated from warning to error. But to get this property, one has to dig into index.js

🤖 Solution

Add error level in rules documentation

🌈 Remarks

Using emoticons may be more readable than text (maybe ⚠️ for warning and 💣 for error?)

💯 Test

Compare with index.js

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@lo1tuma lo1tuma merged commit 9b4b0a4 into lo1tuma:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants