Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [ROCK-3382] Update PR template to follow Loadsmart Change Management Policy #13

Merged
merged 1 commit into from
May 19, 2023

Conversation

pdrowfz
Copy link

@pdrowfz pdrowfz commented May 19, 2023

Motivation and context for the change

Describe the motivation against creating this change and, if applicable, describe the current behavior and any relevant screenshots or diagrams (if applicable).

Loadsmart Change Management Policy requires some fields to be added to the PR template, and labels to be used on the PR. More info on this thread.

A clear description of the change

Describe the change, including new behavior, possible impacts, and any relevant screenshots or diagrams (if applicable).

This PR updates the pull_request_template.md file to follow the new policy.

Showroom

Please include a video or screenshot.

This PR description is written using the new template.

Testing

Inform whether or not the change is covered with automated tests.

  • The change is covered with automated tests

Testing instructions

If the change isn't covered with automated tests, provide a detailed list of steps for the reviewer to test it. You may remove this section in case of automated tests.

Read the new template and check if it follows the guidelines listed here.

Rollback

  • The change can be automatically rolled back

Rollback instructions

If the rollback cannot be performed automatically, provide a detailed list of the steps needed to complete a rollback. Add any relevant link to the documentation if applicable. You may remove this section in case of support for automated rollback.

This is just a documentation change, no rollback necessary.

Jira Ticket

Please include Jira Ticket.

ROCK-3382

Change Management Labels

Based on the Loadsmart Change Management Policy, every change should be documented. The documentation must include the type of the change. Check that this PR is labeled with at least one of the following labels:

  • change-type: infrastructure
  • change-type: source code
  • change-type: database
  • change-type: documentation

@pdrowfz pdrowfz self-assigned this May 19, 2023
@pdrowfz pdrowfz requested review from a team May 19, 2023 15:14
@pdrowfz pdrowfz changed the title docs: update PR template docs: [ROCK-3382] Update PR template to follow Loadsmart Change Management Policy May 19, 2023
@pdrowfz pdrowfz merged commit 76db4cb into master May 19, 2023
@peril-loadsmart peril-loadsmart bot deleted the docs/rock-3382-update-pr-template branch May 19, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants