-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to ROS2 Galactic #271
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work so far, with cherry-picked commits from
devel
andros2
I could use some help making decisions about Time and Parameters
I'm stuck in the weeds in the optimizers, I'm looking forward to getting the unit-tests running for them because I've made a few small mistakes.
The Parameters in particular need updating, ROS2 offers a parameter description available at CLI, and a callback to validate and update the parameters at runtime a bit like the old dynamic_reconfigure. ROS2 also allows nodes to reject new parameters in the update callback.
b0027f1 limits passing of the node to better isolate plugins, but requires the use of the full parameter API, breaking some of 7321776I'm not completely convinced by the approach I'm taking with the Time APIs, and I'd like some discussion there.
ROS2's major strength is multi-agent robotics, and Fuse has the right feature set to do better than NTP/PTP for clock synchronisation between machines.
Using a rough timestamp to order entries in the graph is probably fine, but I feel there needs to be a convention that allows a Constraint to describe a measurement of a remote clock's time, and time-stamping the measurement with the local clock.
ROS2 has migrated the core packages to Apache2 licenses, I'm happy for my work to remain under the existing BSD or to migrate to Apache2 for consistency with ROS2