Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_numeric.js issue #132 #133

Merged
merged 2 commits into from
Jan 17, 2014
Merged

Update is_numeric.js issue #132 #133

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9de7d
Update is_numeric.js
Shnoulle Jan 17, 2014
859cd90
Add and fix testcase comment in is_numeric
Shnoulle Jan 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions functions/var/is_numeric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,19 @@ function is_numeric(mixed_var) {
// + bugfixed by: Tim de Koning
// + bugfixed by: WebDevHobo (http://webdevhobo.blogspot.com/)
// + bugfixed by: Brett Zamir (http://brett-zamir.me)
// + bugfixed by: Denis Chenu (http://shnoulle.net)
// * example 1: is_numeric(186.31);
// * returns 1: true
// * example 2: is_numeric('Kevin van Zonneveld');
// * returns 2: false
// * example 3: is_numeric('+186.31e2');
// * example 3: is_numeric(' +186.31e2');
// * returns 3: true
// * example 4: is_numeric('');
// * returns 4: false
// * example 4: is_numeric([]);
// * returns 4: false
return (typeof mixed_var === 'number' || typeof mixed_var === 'string') && mixed_var !== '' && !isNaN(mixed_var);
// * example 5: is_numeric([]);
// * returns 5: false
// * example 6: is_numeric('1 ');
// * returns 6: false
var whitespace = " \n\r\t\f\x0b\xa0\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200a\u200b\u2028\u2029\u3000";
return (typeof mixed_var === 'number' || (typeof mixed_var === 'string' && whitespace.indexOf(mixed_var.slice(-1)) === -1)) && mixed_var !== '' && !isNaN(mixed_var);
}