Array column with similar core implementation #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvz
added a commit
that referenced
this pull request
Aug 11, 2015
Array column with similar core implementation
kvz
added a commit
that referenced
this pull request
Apr 1, 2016
- update travis - Correct doc typo re 'DIR' vs 'FILE' Close #222 - mention realpath for match event - Be more explicit about which kind of pattern is supported by the `ignore` option. Cf. #207 comment (got stuck into it as well). - Add new fixtures for dot ignore tests - Ignores are always dot:true Fix #223 Fix #226 Fix #166 - code-ify the type defs in API doc - v6.0.0 - Remove negation and comments as promised for v6 - v6.0.1 - Appveyor yml file - remove unnecessary options object manipulation - v6.0.2 - Revert "remove unnecessary options object manipulation" This reverts commit eb6319ff50ae8ef4f9f287fdd4d8f67ba083bba2. Turns out those options ARE relevant, for Minimatch, though not for glob. Oh well. Fix #239 - v6.0.3 - update badges to add appveyor and coveralls remove david-dm, since I don't really get much value out of it. I run 'npm outdated' enough to find issues. - add node 5 to travis-ci - simplify appveyor.yml file Also adds a few details that make things go faster - Upgrade to tap@4 Required a slight change since Istanbul now includes a fs.readdirSync(), which triggered the ENOTSUP test monkeypatch. - Fix appveyor install of node Thanks @appveyor support! - remove util._extend fix #240 - tap@5 - v6.0.4 - Raise error if cwd is not a directory Fix #235 - v7.0.0 - add package name to readme Fix #230 - changelog Fix #179 - Fix race condition when all patterns are ignored Fix #232 - v7.0.1 - Properly exclude dirs using nodir when root is set Fix #221 - update tap to 5.7.0 - v7.0.2 - test: fix some paths for windows - remove incorrect absolute-ness check in makeAbs - Prevent incorrect nodir results on Windows Ensure that everything in the cache always uses correct slashes, and always test against absolute paths when checking anything in the cache. - optimization: only abs the cwd once - v7.0.3 - New: `no-duplicate-imports` rule (fixes #3478) - Docs: Distinguish examples in rules under Variables part 2 - Docs: Distinguish examples in rules under Best Practices part 3 - Fix: Improve file path resolution (fixes #5314) Squashed commits: 28b1368252360ce1f5e01831f4a4339dd43a79b3 Clean up tests fe805b5aa68f63bde521aeee31af94b7224b0efd Further test cleanup c8e45c89d4e4bcf27efbf8106d179d2bde3fa53d Pull out and fix path resolution for ignored-paths 4647bfcb0794fd1cd299d49071e3cc22df3e095a Use process.cwd() at time of construction fb8f2fab0ddb862ad840117d11468a62dd67a2e3 Do not ignore files with `../` as dotfiles ba2cf77c483e0098e11c67963317030b064c349e Consistently use resolved paths abe62795cf9ea6f6efa9fa89476e80d9a56da5b5 Clean up cli.js tests 1a347bb1584258ad47012f38a9725e98f78b7fee Deal with relative file paths f02b1ba5ac9b8204d4d96b7067cf0c0ece3a1525 Shim path.isAbsolute for node 0.10 8510d639523675e0e14c51fa7ef09c4910ba166b Test for file existence before directory check 05ff54994f012269945c5712fd98ca1e1f4b1cf1 Use path-is-absolute ponyfill 34e9a1571bbe686cca7d3e924f4d4b94f9ec4b0c Avoid process.chdir in glob-util tests baaa07e1671eb8515b0a7fb6c3af3cc2c18701ed Force posix style paths a521d6c7f4e5e29ac612e77948978d5bafc1ae26 Update to node-ignore 3.x and address PR comments fc1f56249592c1a94b123d408f015333d37f9221 Update shelljs and glob - Docs: Separate parser and config questions in issue template - Fix: object-curly-spacing doesn't know types (fixes #5537) (fixes #5538) `object-curly-spacing` was blindly checking the penultimate token for `objectsInObjects` and `arraysInObjects` options and it was confusing computed member expressions and function expressions with array and object expressions respectively. This patch adds a type check for the penultimate tokens owner node. - Merge pull request #5541 from platinumazure/issue-template Docs: Separate parser and config questions in issue template - Merge pull request #5545 from eslint/issue-5538 Fix: object-curly-spacing doesn't know types - Fix: `brace-style` erroneously ignoring certain errors (fixes #5197) `brace-style` was ignoring almost all `allman` checks when `allowSingleLine` option was set. It was also ignoring closing brace errors when there was a body error with a single-line body. - Fix: `quote-props` false positive on certain keys (fixes #5532) This patch ensures the "tokenized" version of the key is an exact match to avoid any false positives when the key includes spaces around of it or has "comment blocks" in it such as `//..` or `/*..*/` - Merge pull request #5561 from eslint/issue-5532 Fix: `quote-props` false positive on certain keys - Fix: valid-jsdoc correctly checks type union (fixes #5260) Correctly checks type union when it is a property of type application - Merge pull request #5565 from kaicataldo/fixes5260 Fix: valid-jsdoc correctly checks type union (fixes #5260) - Docs: Make `prefer-template` examples consistent. - Docs: Invalid json in `configuring.md` - Merge pull request #5571 from eslint/docs-prefer-template-examples Docs: Make `prefer-template` examples consistent. - Merge pull request #5572 from eslint/docs-configuring Docs: Invalid json in `configuring.md` - Merge pull request #5461 from eslint/issue5314 Improve file path resolution - Merge pull request #5455 from SimenB/duplicate-imports New: `no-duplicate-imports` rule (fixes #3478) - Docs: Fix typo in CLI help message Use the imperative form like other descriptions. - Fix: `no-useless-constructor` clash (fixes #5573) - Fix: Ensure allowing `await` as a property name (fixes #5564) - Merge pull request #5580 from eslint/no-useless-constructor/fix-crash Fix: `no-useless-constructor` clash (fixes #5573) - Merge pull request #5581 from eslint/core/add-test-for-await Fix: Ensure allowing `await` as a property name (fixes #5564) - Merge pull request #5578 from ryym/cli-help-message Docs: Fix typo in CLI help message - Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522) - Merge pull request #5560 from michaelficarra/GH-5522 Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522) - Merge pull request #5539 from pedrottimark/distinguish-examples-variables-2 Docs: Distinguish examples in rules under Variables part 2 - Merge pull request #5544 from pedrottimark/distinguish-examples-best-practices-3 Docs: Distinguish examples in rules under Best Practices part 3 - Update: Overrides for space-unary-ops (fixes #5060) - Docs: Fix typo in code snippet for no-unmodified-loop-condition rule - Merge pull request #5589 from cvrebert/patch-1 Docs: Fix typo in code snippet for no-unmodified-loop-condition rule - Fix: `prefer-const` got to not change scopes (refs #5284) - Fix: handle personal package.json without config (fixes #5496) - Merge pull request #5528 from dchowitz/issue5496 Fix: handle personal package.json without config (fixes #5496) - Merge pull request #5591 from eslint/prefer-const/ensure-same-scope Fix: `prefer-const` got to not change scopes (refs #5284) - Fix: Respect 'ignoreTrailingComments' in max-len rule (fixes #5563) - Merge pull request #5597 from pvamshi/master Fix: respect 'ignoreTrailingComments' in max-len rule (fixes #5563) - Docs: correct the no-confusing-arrow docs - Merge pull request #5574 from afahim/issue5060 Update: Overrides for space-unary-ops (fixes #5060) - Fix: leading comments added from previous node (fixes #5531) - Merge pull request #5604 from kaicataldo/fixes5531 Fix: leading comments added from previous node (fixes #5531) - Fix: `prefer-const` false positive at non-blocked if (fixes #5610) - Merge pull request #5618 from eslint/prefer-const/fix-non-blocked-if Fix: `prefer-const` false positive at non-blocked if (fixes #5610) - Docs: Remove or rewrite references to former ecmaFeatures - Update: Enforce repo coding conventions via ESLint (refs #5188) Dogfood space-in-parens and lines-around-comment rules in ESLint repo. - Merge pull request #5620 from pedrottimark/former-ecmafeatures Docs: Remove or rewrite references to former ecmaFeatures - Fix: Allow default ignored files to be unignored (fixes #5410) - Docs: Clarify `linebreak-style` docs (fixes #5628) - Merge pull request #5602 from 2color/patch-1 Update no-confusing-arrow.md - Merge pull request #5629 from eslint/issue5628 Docs: Clarify `linebreak-style` docs (fixes #5628) - Update: Allow autoconfiguration for JSX code (fixes #5511) - Merge pull request #5635 from eslint/issue5511 Update: Allow autoconfiguration for JSX code (fixes #5511) - Docs: Update team list with new members - Merge pull request #5637 from eslint/team Docs: Update team list with new members - Docs: Consistent wording in rules README - Docs: Add michaelficarra as committer - Merge pull request #5643 from eslint/docs-new-committer Docs: Add michaelficarra as committer - Docs: Update no-sequences rule docs for clarity (fixes #5536) - Merge pull request #5557 from eslint/issue-5197 Fix: `brace-style` erroneously ignoring certain errors - Merge pull request #5630 from eslint/readme-consistent-wording Docs: Consistent wording in rules README - Merge pull request #5627 from eslint/issue5410 Fix: Allow default ignored files to be unignored (fixes #5410) - Docs: Distinguish examples in rules under Best Practices part 4 - Fix: `--no-ignore` should not un-ignore default ignores (fixes #5547) - Fix: `radix` rule false positive at shadowed variables (fixes #5639) - Upgrade: chai to 3.5.0 (fixes #5647) - Merge pull request #5649 from eslint/issue5647 Upgrade: chai to 3.5.0 (fixes #5647) - Merge pull request #5650 from eslint/fixes5536 Docs: Update no-sequences rule docs for clarity (fixes #5536) - Merge pull request #5596 from pedrottimark/distinguish-examples-best-practices-4 Docs: Distinguish examples in rules under Best Practices part 4 - Docs: Distinguish examples in rules under Node.js and CommonJS - Merge pull request #5642 from eslint/radix/check-shadowing Fix: `radix` rule false positive at shadowed variables (fixes #5639) - Fix: incorrect config message (fixes #5653) Update "warning" to "warn" - Update: Add 'caughtErrors' to rule no-unused-vars (fixes #3837) - Merge pull request #5656 from s0ph1e/fix-incorrect-config-message-for-warn Fix incorrect config message (fixes #5653) - Fix: missing support for json sub configs (fixes #5413) - New: max-statements-per-line (fixes #5424) - Docs: remove brace expansion from configuring.md (refs #5314) Remove mention of brace expansion after conversation in #5314 - Merge pull request #5525 from scriptdaemon/issue-5424 New: max-statements-per-line (fixes #5424) - Merge pull request #5617 from BarryThePenguin/patch-1 Docs: remove brace expansion from configuring.md - Merge pull request #5414 from noamokman/issue5413 Fix: missing support for json sub configs - New: Rule - No useless escape (fixes #5460) - Upgrade: globals 9.x (fixes #5668) - Docs: Add link to "Proposing a Rule Change" in README - Docs: Add link to chat room in README primary links - Build: Fix phantomjs CI problems (fixes #5666) - Merge pull request #5669 from eslint/upgrade-globals Upgrade: globals 9.x (fixes #5668) - Merge pull request #5670 from eslint/docs-readme-rule-changes Docs: Add link to "Proposing a Rule Change" in README - Merge pull request #5671 from eslint/docs-readme-link-chatroom Docs: Add link to chat room in README primary links - Merge pull request #5673 from eslint/issue5666 Build: Add phantomjs cdn to build (fixes #5666) - Merge pull request #5607 from pvamshi/issue3837 Update: Add 'caughtErrors' to rule no-unused-vars (fixes #3837) - Merge pull request #5632 from onurtemizkan/issue-5460 New: Rule - No useless escape (fixes #5460) - Merge pull request #5648 from eslint/issue5547 Fix: `--no-ignore` should not un-ignore default ignores (fixes #5547) - Docs: Clarify --ext does not apply to globs (fixes #5452) - Merge pull request #5598 from pedrottimark/distinguish-examples-nodejs-common-js Docs: Distinguish examples in rules under Node.js and CommonJS - Merge pull request #5622 from platinumazure/eslint-config-in-line-1 Update: Enforce repo coding conventions via ESLint (refs #5188) - Merge pull request #5625 from eslint/issue5452 Docs: Clarify --ext does not apply to globs (fixes #5452) - Build: Bundle dependencies in package.json (fixes #5013) This adds the bundledDependencies section to package.json and also upgrades eslint-release to the version that will update the bundled dependencies as part of the release. - Merge pull request #5676 from eslint/issue5013 Build: Bundle dependencies in package.json (fixes #5013) - Docs: Remove ES2016 from experimental section of README Also added a section indicating criteria for when we will consider those features for ESLint rules (i.e., when it has been added to the ECMAScript standard). - Merge pull request #5576 from platinumazure/readme-experimental-edit Docs: Remove ES2016 from experimental section of README - Fix: lines-around-comment in ESLint repo, part 2 (refs #5188) - Merge pull request #5677 from platinumazure/lines-around-comment Fix: lines-around-comment in ESLint repo, part 2 (refs #5188) - Build: package.json and changelog update for 2.5.0 - 2.5.0 - Fix: don't use path.extname with undefined value (fixes #5678) In the current versions of node path.* can be called on any arbitrary value and will return an empty string on invalid input. As of node v6 path will assert that values passed to it are strings, and as such will throw on `undefined` This commit moved the logic of using `path.extname` inside of the processText function in `lib/cli-engine.js`. so that it will not call `path.extname` if a filename is not passed. This change should not affect any other parts of the system, and the test suite is 100% working on node v4, v5, and master. fixes #5678 - 2.5.1 - Docs: Manual changelog update for v2.5.1 - Docs: Use string severity - Merge pull request #5684 from scriptdaemon/docs-string-severity Docs: Use string severity - Docs: Typo fix Changed article from "an" to "a" in front of "string". - Build: Fix bundling script (fixes #5680) - Merge pull request #5663 from Isti115/patch-1 Docs: Fix: Typo - Merge pull request #5688 from eslint/issue5680 Build: Fix bundling script (fixes #5680) - Docs: Distinguish examples in rules under Best Practices part 2 - Merge pull request #5506 from pedrottimark/distinguish-examples-best-practices-2 Docs: Distinguish examples in rules under Best Practices part 2 - Merge pull request #5683 from TheAlphaNerd/validate-before-using-path fix: don't use path.extname with undefined value - Fix: make the default of `options.cwd` in runtime (fixes #5694) - Merge pull request #5697 from eslint/core/fix-default-of-cliengine-cwd Fix: make the default of `options.cwd` in runtime (fixes #5694) - Fix: Correct default for indentation in `eslint --init` (fixes #5698) - Docs: Reorder FAQ in README - Merge pull request #5699 from eslint/issue5698 Fix: Correct default for indentation in `eslint --init` (fixes #5698) - Docs: Remove mention of minimatch for .eslintignore We no longer use minimatch for ignore patterns, instead using `ignore` to match `.gitignore` format exactly. - Merge pull request #5702 from eslint/doc-eslintignore Docs: Remove mention of minimatch for .eslintignore - Merge pull request #5700 from eslint/docs-readme-faq Docs: Reorder FAQ in README - Build: package.json and changelog update for 2.5.2 - 2.5.2 - Build: Disable bundling dependencies (fixes #5687) - Merge pull request #5708 from eslint/issue5687 Build: Disable bundling dependencies (fixes #5687) - Build: package.json and changelog update for 2.5.3 - 2.5.3 - Fix typo in test/reporters/nyan.js peinding -> pending - Merge pull request #1909 from berkerpeksag/patch-1 Fix typo in test/reporters/nyan.js - remove duplication of mocha.opts on process.argv - MERge pull request #1910 from nexdrew/fix/mocha-opts-dupe Fix duplication of mocha.opts on process.argv - Update debug dependency to 2.2.0 debug@2.0.0 has a vulnerability in its dependency on ms@0.6.2. debug@2.2.0 has updated its ms dependency to a version without this vulnerability. - Merge pull request #1954 from joeycozza/master Update debug dependency to 2.2.0 - Release 2.3.4 - Silence Bluebird js warnings - Merge pull request #1967 from krisr/kris-silence-warnings Silence Bluebird js warnings - Fixes #1794 Moves Mocha interface allocation to after require option has been processed to allow for use of custom Mocha UI's. - Simplify function call. - support --perf-basic-prof - use chalk for base reporter colors; closes #1200 - propagate "file" property across suites and tests for "exports" interface - make sure the xunit output dir exists before trying to write to it Fixes #1994 - fix lint errors - Merge pull request #1995 from ianwremmel/fix-xunit-hang make sure the xunit output dir exists before trying to write to it - support for strict mode - fixes #1879 - fixes #1821 - XUnit Reporter Writes to stdout, falls back to console.log Fixes #1674; provides support *much* needed for [mocha-phantomjs](https://github.com/nathanboktae/mocha-phantomjs) (see [#133](nathanboktae/mocha-phantomjs#133), [#220](nathanboktae/mocha-phantomjs#220), etc). Maintains support for running the XUnit reporter in a browser (unlike the previously reverted PR #1068). ping @alemangui, @nathanboktae Thanks all. - Fix HTML reporting display to show errors if done is called multiple times, or if an exception is thrown after done is called. - Fix non ES5 regexp ES5 appears to require that { be escaped when not used as part of a quantifier. While this works fine in browsers it appears to choke less lenient runtimes (e.g. Duktape) - always reference the correct it from it.only - Merge pull request #1965 from cowboyd/dont-double-install-bdd-ui Dont double install bdd ui - Merge pull request #2021 from zetaben/patch-1 Fix non ES5 compliant regexp - Alter feature detection - Merge pull request #2005 from jonnyreeves/patch-1 XUnit Reporter Writes to stdout, falls back to console.log - Merge pull request #1999 from tmont/use-strict-fix support for strict mode - Merge pull request #1993 from segrey/master propagate "file" property across suites and tests for "exports" inter… - Merge pull request #1981 from Standard8/fix-done-reporting-on-html Fix HTML reporting display to show errors if done is called multiple times, or if an exception is thrown after done is called. - Merge pull request #1963 from peachworks/perf-basic-prof Add support --perf-basic-prof - 1794 test case - Fix fixtures/regression/1794/simple-ui.js to work with local mocha - Merge branch 'ui-fix' - Merge pull request #1976 from iclanzan/patch-1 Simplify function call. - Fix #1980: Load mocha.opts from bin/mocha and bin/_mocha - Allow to retry failed test from test context for #1773 - make retries run proper hooks - allow retries override at different levels - expose currentRetry to reporters - Enable --log-timer-events option This provides better insights when profiling application using --prof switch. Especially useful when the log is processed by https://v8.googlecode.com/svn/branches/bleeding_edge/tools/profviz/profviz.html. - Merge pull request #1982 from Alaneor/cli-log-timer-events Enable --log-timer-events option - Merge pull request #1989 from longlho/1773-retries Allow to retry failed test from test context for #1773 - safely stringify PhantomJS undefined value - Merge pull request #1977 from ahamid/handle-phantomjs-undefined safely stringify PhantomJS undefined value - Remove reference to test before afterAll hook runs Fix #2006 - Merge pull request #2028 from stonelgh/remove-reference-to-test-try2 Remove reference to test before afterAll hook runs - Bump mkdirp to 0.5.1 to support strict mode - Update tests for newer versions of should.js - Fix for memory leak caused by referenced to deferred test functions (it/before[Each]/after[Each]). related to #1991. - Also run travis build on node.js 4 & 5. - Merge pull request #2038 from bd82/travis Also run Travis-CI on node.js 4 & 5 - Merge pull request #2037 from bd82/master Fix for memory leak caused by referenced to deferred test functions - Merge pull request #2033 from tomhughes/should Update tests for newer versions of should.js - add clone capability to test, fix async retry, fix #2045 - Merge pull request #2047 from longlho/retry-fix add clone capability to test, fix async retry, fix #2045 - Enable `this.skip()` within individual test at runtime References #946 - Merge pull request #2048 from mislav/fix-skip Fix `this.skip` from spec with HTML reporter - Fix integration tests: remove .only() - Have global exports be compatible with Web Workers Assigning to `window` only works in a normal browser environment; however, Web Workers don't have access to `window`. Instead, the global object inside Web Workers is `self`. Browserify ensures that `global` is present to all scripts by creating a shim reference to it using this logic: typeof global !== "undefined" ? global : typeof self !== "undefined" ? self : typeof window !== "undefined" ? window : {} Thus, if neither `global` nor `self` were originally present, `global === window` will be true. Web Workers compatibility was broken in a81e5558. - chore(license): update license year to 2016 - Merge pull request #2056 from pra85/patch-1 chore(license): update license year to 2016 - Correctly skip tests when skipping in a suites before() - Merge pull request #1945 from ryanshawty/master Correctly skip tests when skipping in a suites before() - Fix test fn's being deleted too early for browser reporter - Merge pull request #2066 from danielstjules/dstjules/fix-browser Fix test fn's being deleted too early for browser reporter - Release 2.4.0 - Build browser mocha for 2.4.0 - Fix #2067: HTML/DOC reporter regression with async failures - Merge pull request #2068 from danielstjules/dstjules/test-body Fix 2067: HTML/DOC reporter regression with async failures - increase retry test timeout - rename HISTORY.md => CHANGELOG.md - rebuild mocha.js - Release v2.4.1 - Merge pull request #2053 from mislav/window-vs-global Have global exports be compatible with Web Workers - Fix #2071: Removed color code to fix Chalk colors - Merge pull request #2072 from thedark1337/master Fix #2071: Removed color code to fix Chalk colors - Fix: reporters with chalk functions (fixes #2073) - Merge pull request #2074 from gyandeeps/master Fix: reporters with chalk functions (fixes #2073) - update CHANGELOG; add link to CHANGELOG in README.md - rebuild - Release v2.4.2 - Add missing heading style - stub chalk in browser, closes #2078 - Release v2.4.3 - Merge pull request #2076 from rstacruz/patch-2 Add missing heading style - use browser field instead of --require; closes #2080 - update changelog - Release v2.4.4 - Fix a number of assertions that weren't asserting anything They were missing parentheses and thus no assertion method was ever executed. - Merge pull request #2082 from mislav/fix-assertions Fix a number of assertions that weren't asserting anything - add npm-debug.log to .gitignore - reverts usage of chalk and all chalk-related changes thereafter; closes #2080 reverts: - 4b37877bc0ab72b6782a8a5b38fbb86a6a2a3475 - a4345efe0de0f80d09b35794f5e130d730542def - 9f3774f7beaad3f26d88313205ff6796a84b2f83 - 119291449cd03a11cdeda9e37cf718a69a012896 - update CHANGELOG.md for forthcoming v2.4.5 release - Release v2.4.5
kvz
added a commit
that referenced
this pull request
Apr 1, 2016
Squashed commit of the following:
commit 78c99cc851b867330a9f42c06cb2ff8ce7cbcbdc
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 14:21:32 2016 +0200
Standard Coding Style post
commit dfdf075
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 13:50:45 2016 +0200
Exclude a few rules
commit d38d8fa
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 13:31:16 2016 +0200
Add back js-beautify
commit c88ab28
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 13:21:08 2016 +0200
Upgrade node dependencies
- update travis
- Correct doc typo re 'DIR' vs 'FILE'
Close #222
- mention realpath for match event
- Be more explicit about which kind of pattern is supported by the `ignore` option.
Cf. #207 comment (got stuck into it as well).
- Add new fixtures for dot ignore tests
- Ignores are always dot:true
Fix #223
Fix #226
Fix #166
- code-ify the type defs in API doc
- v6.0.0
- Remove negation and comments as promised for v6
- v6.0.1
- Appveyor yml file
- remove unnecessary options object manipulation
- v6.0.2
- Revert "remove unnecessary options object manipulation"
This reverts commit eb6319ff50ae8ef4f9f287fdd4d8f67ba083bba2.
Turns out those options ARE relevant, for Minimatch, though not for
glob. Oh well.
Fix #239
- v6.0.3
- update badges to add appveyor and coveralls
remove david-dm, since I don't really get much value out of it. I run
'npm outdated' enough to find issues.
- add node 5 to travis-ci
- simplify appveyor.yml file
Also adds a few details that make things go faster
- Upgrade to tap@4
Required a slight change since Istanbul now includes a
fs.readdirSync(), which triggered the ENOTSUP test monkeypatch.
- Fix appveyor install of node
Thanks @appveyor support!
- remove util._extend
fix #240
- tap@5
- v6.0.4
- Raise error if cwd is not a directory
Fix #235
- v7.0.0
- add package name to readme
Fix #230
- changelog
Fix #179
- Fix race condition when all patterns are ignored
Fix #232
- v7.0.1
- Properly exclude dirs using nodir when root is set
Fix #221
- update tap to 5.7.0
- v7.0.2
- test: fix some paths for windows
- remove incorrect absolute-ness check in makeAbs
- Prevent incorrect nodir results on Windows
Ensure that everything in the cache always uses correct slashes, and
always test against absolute paths when checking anything in the cache.
- optimization: only abs the cwd once
- v7.0.3
- New: `no-duplicate-imports` rule (fixes #3478)
- Docs: Distinguish examples in rules under Variables part 2
- Docs: Distinguish examples in rules under Best Practices part 3
- Fix: Improve file path resolution (fixes #5314)
Squashed commits:
28b1368252360ce1f5e01831f4a4339dd43a79b3 Clean up tests
fe805b5aa68f63bde521aeee31af94b7224b0efd Further test cleanup
c8e45c89d4e4bcf27efbf8106d179d2bde3fa53d Pull out and fix path resolution for ignored-paths
4647bfcb0794fd1cd299d49071e3cc22df3e095a Use process.cwd() at time of construction
fb8f2fab0ddb862ad840117d11468a62dd67a2e3 Do not ignore files with `../` as dotfiles
ba2cf77c483e0098e11c67963317030b064c349e Consistently use resolved paths
abe62795cf9ea6f6efa9fa89476e80d9a56da5b5 Clean up cli.js tests
1a347bb1584258ad47012f38a9725e98f78b7fee Deal with relative file paths
f02b1ba5ac9b8204d4d96b7067cf0c0ece3a1525 Shim path.isAbsolute for node 0.10
8510d639523675e0e14c51fa7ef09c4910ba166b Test for file existence before directory check
05ff54994f012269945c5712fd98ca1e1f4b1cf1 Use path-is-absolute ponyfill
34e9a1571bbe686cca7d3e924f4d4b94f9ec4b0c Avoid process.chdir in glob-util tests
baaa07e1671eb8515b0a7fb6c3af3cc2c18701ed Force posix style paths
a521d6c7f4e5e29ac612e77948978d5bafc1ae26 Update to node-ignore 3.x and address PR comments
fc1f56249592c1a94b123d408f015333d37f9221 Update shelljs and glob
- Docs: Separate parser and config questions in issue template
- Fix: object-curly-spacing doesn't know types (fixes #5537) (fixes #5538)
`object-curly-spacing` was blindly checking the penultimate token for
`objectsInObjects` and `arraysInObjects` options and it was confusing
computed member expressions and function expressions with array and
object expressions respectively. This patch adds a type check for the
penultimate tokens owner node.
- Merge pull request #5541 from platinumazure/issue-template
Docs: Separate parser and config questions in issue template
- Merge pull request #5545 from eslint/issue-5538
Fix: object-curly-spacing doesn't know types
- Fix: `brace-style` erroneously ignoring certain errors (fixes #5197)
`brace-style` was ignoring almost all `allman` checks when
`allowSingleLine` option was set. It was also ignoring closing brace
errors when there was a body error with a single-line body.
- Fix: `quote-props` false positive on certain keys (fixes #5532)
This patch ensures the "tokenized" version of the key is an exact match
to avoid any false positives when the key includes spaces around of it
or has "comment blocks" in it such as `//..` or `/*..*/`
- Merge pull request #5561 from eslint/issue-5532
Fix: `quote-props` false positive on certain keys
- Fix: valid-jsdoc correctly checks type union (fixes #5260)
Correctly checks type union when it is a property of type application
- Merge pull request #5565 from kaicataldo/fixes5260
Fix: valid-jsdoc correctly checks type union (fixes #5260)
- Docs: Make `prefer-template` examples consistent.
- Docs: Invalid json in `configuring.md`
- Merge pull request #5571 from eslint/docs-prefer-template-examples
Docs: Make `prefer-template` examples consistent.
- Merge pull request #5572 from eslint/docs-configuring
Docs: Invalid json in `configuring.md`
- Merge pull request #5461 from eslint/issue5314
Improve file path resolution
- Merge pull request #5455 from SimenB/duplicate-imports
New: `no-duplicate-imports` rule (fixes #3478)
- Docs: Fix typo in CLI help message
Use the imperative form like other descriptions.
- Fix: `no-useless-constructor` clash (fixes #5573)
- Fix: Ensure allowing `await` as a property name (fixes #5564)
- Merge pull request #5580 from eslint/no-useless-constructor/fix-crash
Fix: `no-useless-constructor` clash (fixes #5573)
- Merge pull request #5581 from eslint/core/add-test-for-await
Fix: Ensure allowing `await` as a property name (fixes #5564)
- Merge pull request #5578 from ryym/cli-help-message
Docs: Fix typo in CLI help message
- Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522)
- Merge pull request #5560 from michaelficarra/GH-5522
Update: replace MD5 hashing of cache files with MurmurHash (fixes #5522)
- Merge pull request #5539 from pedrottimark/distinguish-examples-variables-2
Docs: Distinguish examples in rules under Variables part 2
- Merge pull request #5544 from pedrottimark/distinguish-examples-best-practices-3
Docs: Distinguish examples in rules under Best Practices part 3
- Update: Overrides for space-unary-ops (fixes #5060)
- Docs: Fix typo in code snippet for no-unmodified-loop-condition rule
- Merge pull request #5589 from cvrebert/patch-1
Docs: Fix typo in code snippet for no-unmodified-loop-condition rule
- Fix: `prefer-const` got to not change scopes (refs #5284)
- Fix: handle personal package.json without config (fixes #5496)
- Merge pull request #5528 from dchowitz/issue5496
Fix: handle personal package.json without config (fixes #5496)
- Merge pull request #5591 from eslint/prefer-const/ensure-same-scope
Fix: `prefer-const` got to not change scopes (refs #5284)
- Fix: Respect 'ignoreTrailingComments' in max-len rule (fixes #5563)
- Merge pull request #5597 from pvamshi/master
Fix: respect 'ignoreTrailingComments' in max-len rule (fixes #5563)
- Docs: correct the no-confusing-arrow docs
- Merge pull request #5574 from afahim/issue5060
Update: Overrides for space-unary-ops (fixes #5060)
- Fix: leading comments added from previous node (fixes #5531)
- Merge pull request #5604 from kaicataldo/fixes5531
Fix: leading comments added from previous node (fixes #5531)
- Fix: `prefer-const` false positive at non-blocked if (fixes #5610)
- Merge pull request #5618 from eslint/prefer-const/fix-non-blocked-if
Fix: `prefer-const` false positive at non-blocked if (fixes #5610)
- Docs: Remove or rewrite references to former ecmaFeatures
- Update: Enforce repo coding conventions via ESLint (refs #5188)
Dogfood space-in-parens and lines-around-comment rules in ESLint repo.
- Merge pull request #5620 from pedrottimark/former-ecmafeatures
Docs: Remove or rewrite references to former ecmaFeatures
- Fix: Allow default ignored files to be unignored (fixes #5410)
- Docs: Clarify `linebreak-style` docs (fixes #5628)
- Merge pull request #5602 from 2color/patch-1
Update no-confusing-arrow.md
- Merge pull request #5629 from eslint/issue5628
Docs: Clarify `linebreak-style` docs (fixes #5628)
- Update: Allow autoconfiguration for JSX code (fixes #5511)
- Merge pull request #5635 from eslint/issue5511
Update: Allow autoconfiguration for JSX code (fixes #5511)
- Docs: Update team list with new members
- Merge pull request #5637 from eslint/team
Docs: Update team list with new members
- Docs: Consistent wording in rules README
- Docs: Add michaelficarra as committer
- Merge pull request #5643 from eslint/docs-new-committer
Docs: Add michaelficarra as committer
- Docs: Update no-sequences rule docs for clarity (fixes #5536)
- Merge pull request #5557 from eslint/issue-5197
Fix: `brace-style` erroneously ignoring certain errors
- Merge pull request #5630 from eslint/readme-consistent-wording
Docs: Consistent wording in rules README
- Merge pull request #5627 from eslint/issue5410
Fix: Allow default ignored files to be unignored (fixes #5410)
- Docs: Distinguish examples in rules under Best Practices part 4
- Fix: `--no-ignore` should not un-ignore default ignores (fixes #5547)
- Fix: `radix` rule false positive at shadowed variables (fixes #5639)
- Upgrade: chai to 3.5.0 (fixes #5647)
- Merge pull request #5649 from eslint/issue5647
Upgrade: chai to 3.5.0 (fixes #5647)
- Merge pull request #5650 from eslint/fixes5536
Docs: Update no-sequences rule docs for clarity (fixes #5536)
- Merge pull request #5596 from pedrottimark/distinguish-examples-best-practices-4
Docs: Distinguish examples in rules under Best Practices part 4
- Docs: Distinguish examples in rules under Node.js and CommonJS
- Merge pull request #5642 from eslint/radix/check-shadowing
Fix: `radix` rule false positive at shadowed variables (fixes #5639)
- Fix: incorrect config message (fixes #5653)
Update "warning" to "warn"
- Update: Add 'caughtErrors' to rule no-unused-vars (fixes #3837)
- Merge pull request #5656 from s0ph1e/fix-incorrect-config-message-for-warn
Fix incorrect config message (fixes #5653)
- Fix: missing support for json sub configs (fixes #5413)
- New: max-statements-per-line (fixes #5424)
- Docs: remove brace expansion from configuring.md (refs #5314)
Remove mention of brace expansion after conversation in #5314
- Merge pull request #5525 from scriptdaemon/issue-5424
New: max-statements-per-line (fixes #5424)
- Merge pull request #5617 from BarryThePenguin/patch-1
Docs: remove brace expansion from configuring.md
- Merge pull request #5414 from noamokman/issue5413
Fix: missing support for json sub configs
- New: Rule - No useless escape (fixes #5460)
- Upgrade: globals 9.x (fixes #5668)
- Docs: Add link to "Proposing a Rule Change" in README
- Docs: Add link to chat room in README primary links
- Build: Fix phantomjs CI problems (fixes #5666)
- Merge pull request #5669 from eslint/upgrade-globals
Upgrade: globals 9.x (fixes #5668)
- Merge pull request #5670 from eslint/docs-readme-rule-changes
Docs: Add link to "Proposing a Rule Change" in README
- Merge pull request #5671 from eslint/docs-readme-link-chatroom
Docs: Add link to chat room in README primary links
- Merge pull request #5673 from eslint/issue5666
Build: Add phantomjs cdn to build (fixes #5666)
- Merge pull request #5607 from pvamshi/issue3837
Update: Add 'caughtErrors' to rule no-unused-vars (fixes #3837)
- Merge pull request #5632 from onurtemizkan/issue-5460
New: Rule - No useless escape (fixes #5460)
- Merge pull request #5648 from eslint/issue5547
Fix: `--no-ignore` should not un-ignore default ignores (fixes #5547)
- Docs: Clarify --ext does not apply to globs (fixes #5452)
- Merge pull request #5598 from pedrottimark/distinguish-examples-nodejs-common-js
Docs: Distinguish examples in rules under Node.js and CommonJS
- Merge pull request #5622 from platinumazure/eslint-config-in-line-1
Update: Enforce repo coding conventions via ESLint (refs #5188)
- Merge pull request #5625 from eslint/issue5452
Docs: Clarify --ext does not apply to globs (fixes #5452)
- Build: Bundle dependencies in package.json (fixes #5013)
This adds the bundledDependencies section to package.json and also
upgrades eslint-release to the version that will update the bundled
dependencies as part of the release.
- Merge pull request #5676 from eslint/issue5013
Build: Bundle dependencies in package.json (fixes #5013)
- Docs: Remove ES2016 from experimental section of README
Also added a section indicating criteria for when we will consider those features for ESLint rules (i.e., when it has been added to the ECMAScript standard).
- Merge pull request #5576 from platinumazure/readme-experimental-edit
Docs: Remove ES2016 from experimental section of README
- Fix: lines-around-comment in ESLint repo, part 2 (refs #5188)
- Merge pull request #5677 from platinumazure/lines-around-comment
Fix: lines-around-comment in ESLint repo, part 2 (refs #5188)
- Build: package.json and changelog update for 2.5.0
- 2.5.0
- Fix: don't use path.extname with undefined value (fixes #5678)
In the current versions of node path.* can be called on any arbitrary
value and will return an empty string on invalid input.
As of node v6 path will assert that values passed to it are strings,
and as such will throw on `undefined`
This commit moved the logic of using `path.extname` inside of the
processText function in `lib/cli-engine.js`. so that it will not call
`path.extname` if a filename is not passed.
This change should not affect any other parts of the system, and the
test suite is 100% working on node v4, v5, and master.
fixes #5678
- 2.5.1
- Docs: Manual changelog update for v2.5.1
- Docs: Use string severity
- Merge pull request #5684 from scriptdaemon/docs-string-severity
Docs: Use string severity
- Docs: Typo fix
Changed article from "an" to "a" in front of "string".
- Build: Fix bundling script (fixes #5680)
- Merge pull request #5663 from Isti115/patch-1
Docs: Fix: Typo
- Merge pull request #5688 from eslint/issue5680
Build: Fix bundling script (fixes #5680)
- Docs: Distinguish examples in rules under Best Practices part 2
- Merge pull request #5506 from pedrottimark/distinguish-examples-best-practices-2
Docs: Distinguish examples in rules under Best Practices part 2
- Merge pull request #5683 from TheAlphaNerd/validate-before-using-path
fix: don't use path.extname with undefined value
- Fix: make the default of `options.cwd` in runtime (fixes #5694)
- Merge pull request #5697 from eslint/core/fix-default-of-cliengine-cwd
Fix: make the default of `options.cwd` in runtime (fixes #5694)
- Fix: Correct default for indentation in `eslint --init` (fixes #5698)
- Docs: Reorder FAQ in README
- Merge pull request #5699 from eslint/issue5698
Fix: Correct default for indentation in `eslint --init` (fixes #5698)
- Docs: Remove mention of minimatch for .eslintignore
We no longer use minimatch for ignore patterns, instead using `ignore`
to match `.gitignore` format exactly.
- Merge pull request #5702 from eslint/doc-eslintignore
Docs: Remove mention of minimatch for .eslintignore
- Merge pull request #5700 from eslint/docs-readme-faq
Docs: Reorder FAQ in README
- Build: package.json and changelog update for 2.5.2
- 2.5.2
- Build: Disable bundling dependencies (fixes #5687)
- Merge pull request #5708 from eslint/issue5687
Build: Disable bundling dependencies (fixes #5687)
- Build: package.json and changelog update for 2.5.3
- 2.5.3
- Fix typo in test/reporters/nyan.js
peinding -> pending
- Merge pull request #1909 from berkerpeksag/patch-1
Fix typo in test/reporters/nyan.js
- remove duplication of mocha.opts on process.argv
- MERge pull request #1910 from nexdrew/fix/mocha-opts-dupe
Fix duplication of mocha.opts on process.argv
- Update debug dependency to 2.2.0
debug@2.0.0 has a vulnerability in its dependency on ms@0.6.2.
debug@2.2.0 has updated its ms dependency to a version without this vulnerability.
- Merge pull request #1954 from joeycozza/master
Update debug dependency to 2.2.0
- Release 2.3.4
- Silence Bluebird js warnings
- Merge pull request #1967 from krisr/kris-silence-warnings
Silence Bluebird js warnings
- Fixes #1794
Moves Mocha interface allocation to after require option has been processed to allow for use of custom Mocha UI's.
- Simplify function call.
- support --perf-basic-prof
- use chalk for base reporter colors; closes #1200
- propagate "file" property across suites and tests for "exports" interface
- make sure the xunit output dir exists before trying to write to it
Fixes #1994
- fix lint errors
- Merge pull request #1995 from ianwremmel/fix-xunit-hang
make sure the xunit output dir exists before trying to write to it
- support for strict mode
- fixes #1879
- fixes #1821
- XUnit Reporter Writes to stdout, falls back to console.log
Fixes #1674; provides support *much* needed for [mocha-phantomjs](https://github.com/nathanboktae/mocha-phantomjs) (see [#133](nathanboktae/mocha-phantomjs#133), [#220](nathanboktae/mocha-phantomjs#220), etc). Maintains support for running the XUnit reporter in a browser (unlike the previously reverted PR #1068).
ping @alemangui, @nathanboktae
Thanks all.
- Fix HTML reporting display to show errors if done is called multiple times, or if an exception is thrown after done is called.
- Fix non ES5 regexp
ES5 appears to require that { be escaped when not used as part of a quantifier. While this works fine in browsers it appears to choke less lenient runtimes (e.g. Duktape)
- always reference the correct it from it.only
- Merge pull request #1965 from cowboyd/dont-double-install-bdd-ui
Dont double install bdd ui
- Merge pull request #2021 from zetaben/patch-1
Fix non ES5 compliant regexp
- Alter feature detection
- Merge pull request #2005 from jonnyreeves/patch-1
XUnit Reporter Writes to stdout, falls back to console.log
- Merge pull request #1999 from tmont/use-strict-fix
support for strict mode
- Merge pull request #1993 from segrey/master
propagate "file" property across suites and tests for "exports" inter…
- Merge pull request #1981 from Standard8/fix-done-reporting-on-html
Fix HTML reporting display to show errors if done is called multiple times, or if an exception is thrown after done is called.
- Merge pull request #1963 from peachworks/perf-basic-prof
Add support --perf-basic-prof
- 1794 test case
- Fix fixtures/regression/1794/simple-ui.js to work with local mocha
- Merge branch 'ui-fix'
- Merge pull request #1976 from iclanzan/patch-1
Simplify function call.
- Fix #1980: Load mocha.opts from bin/mocha and bin/_mocha
- Allow to retry failed test from test context for #1773
- make retries run proper hooks
- allow retries override at different levels
- expose currentRetry to reporters
- Enable --log-timer-events option
This provides better insights when profiling application using --prof switch. Especially useful when the log is processed by https://v8.googlecode.com/svn/branches/bleeding_edge/tools/profviz/profviz.html.
- Merge pull request #1982 from Alaneor/cli-log-timer-events
Enable --log-timer-events option
- Merge pull request #1989 from longlho/1773-retries
Allow to retry failed test from test context for #1773
- safely stringify PhantomJS undefined value
- Merge pull request #1977 from ahamid/handle-phantomjs-undefined
safely stringify PhantomJS undefined value
- Remove reference to test before afterAll hook runs
Fix #2006
- Merge pull request #2028 from stonelgh/remove-reference-to-test-try2
Remove reference to test before afterAll hook runs
- Bump mkdirp to 0.5.1 to support strict mode
- Update tests for newer versions of should.js
- Fix for memory leak caused by referenced to deferred test functions
(it/before[Each]/after[Each]).
related to #1991.
- Also run travis build on node.js 4 & 5.
- Merge pull request #2038 from bd82/travis
Also run Travis-CI on node.js 4 & 5
- Merge pull request #2037 from bd82/master
Fix for memory leak caused by referenced to deferred test functions
- Merge pull request #2033 from tomhughes/should
Update tests for newer versions of should.js
- add clone capability to test, fix async retry, fix #2045
- Merge pull request #2047 from longlho/retry-fix
add clone capability to test, fix async retry, fix #2045
- Enable `this.skip()` within individual test at runtime
References #946
- Merge pull request #2048 from mislav/fix-skip
Fix `this.skip` from spec with HTML reporter
- Fix integration tests: remove .only()
- Have global exports be compatible with Web Workers
Assigning to `window` only works in a normal browser environment;
however, Web Workers don't have access to `window`. Instead, the global
object inside Web Workers is `self`.
Browserify ensures that `global` is present to all scripts by creating a
shim reference to it using this logic:
typeof global !== "undefined" ? global :
typeof self !== "undefined" ? self :
typeof window !== "undefined" ? window : {}
Thus, if neither `global` nor `self` were originally present,
`global === window` will be true.
Web Workers compatibility was broken in a81e5558.
- chore(license): update license year to 2016
- Merge pull request #2056 from pra85/patch-1
chore(license): update license year to 2016
- Correctly skip tests when skipping in a suites before()
- Merge pull request #1945 from ryanshawty/master
Correctly skip tests when skipping in a suites before()
- Fix test fn's being deleted too early for browser reporter
- Merge pull request #2066 from danielstjules/dstjules/fix-browser
Fix test fn's being deleted too early for browser reporter
- Release 2.4.0
- Build browser mocha for 2.4.0
- Fix #2067: HTML/DOC reporter regression with async failures
- Merge pull request #2068 from danielstjules/dstjules/test-body
Fix 2067: HTML/DOC reporter regression with async failures
- increase retry test timeout
- rename HISTORY.md => CHANGELOG.md
- rebuild mocha.js
- Release v2.4.1
- Merge pull request #2053 from mislav/window-vs-global
Have global exports be compatible with Web Workers
- Fix #2071: Removed color code to fix Chalk colors
- Merge pull request #2072 from thedark1337/master
Fix #2071: Removed color code to fix Chalk colors
- Fix: reporters with chalk functions (fixes #2073)
- Merge pull request #2074 from gyandeeps/master
Fix: reporters with chalk functions (fixes #2073)
- update CHANGELOG; add link to CHANGELOG in README.md
- rebuild
- Release v2.4.2
- Add missing heading style
- stub chalk in browser, closes #2078
- Release v2.4.3
- Merge pull request #2076 from rstacruz/patch-2
Add missing heading style
- use browser field instead of --require; closes #2080
- update changelog
- Release v2.4.4
- Fix a number of assertions that weren't asserting anything
They were missing parentheses and thus no assertion method was ever executed.
- Merge pull request #2082 from mislav/fix-assertions
Fix a number of assertions that weren't asserting anything
- add npm-debug.log to .gitignore
- reverts usage of chalk and all chalk-related changes thereafter; closes #2080
reverts:
- 4b37877bc0ab72b6782a8a5b38fbb86a6a2a3475
- a4345efe0de0f80d09b35794f5e130d730542def
- 9f3774f7beaad3f26d88313205ff6796a84b2f83
- 119291449cd03a11cdeda9e37cf718a69a012896
- update CHANGELOG.md for forthcoming v2.4.5 release
- Release v2.4.5
commit efa1356
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 13:20:00 2016 +0200
First run of eslint fixes
commit bffdd8c
Author: Kevin van Zonneveld <kevin@vanzonneveld.net>
Date: Fri Apr 1 13:18:50 2016 +0200
Switch to eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just implemented
array_columnwith a similar implementation that happens on PHP core. It is yet experimental.