Capture return code and use it for --run

refs idaholab#28639

examples/ex01_inputfile/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex02_kernel/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex03_coupling/src/main.C

@@ -22,7 +22,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex04_bcs/src/main.C

@@ -21,7 +21,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex05_amr/src/main.C

@@ -21,7 +21,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex06_transient/src/main.C

@@ -22,7 +22,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex07_ics/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex08_materials/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex09_stateful_materials/src/main.C

@@ -22,7 +22,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex10_aux/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex11_prec/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex12_pbp/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex13_functions/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex14_pps/src/main.C

@@ -25,7 +25,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex15_actions/src/main.C

@@ -22,7 +22,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex16_timestepper/src/main.C

@@ -22,7 +22,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex17_dirac/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex18_scalar_kernel/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex19_dampers/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex20_user_objects/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

examples/ex21_debugging/src/main.C

@@ -20,7 +20,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExampleApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExampleApp>(argc, argv);
 }

framework/include/base/MooseApp.h

@@ -128,6 +128,12 @@ class MooseApp : public ConsoleStreamInterface,
     return name;
   }
 
+  /**
+   * Get the shell exit code for the application
+   * @return The shell exit code
+   */
+  int exitCode() const { return _exit_code; }
+
   /**
    * Get the parameters of the object
    * @return The parameters of the object
@@ -1234,6 +1240,8 @@ class MooseApp : public ConsoleStreamInterface,
   /// Indicates whether warnings or errors are displayed when overridden parameters are detected
   bool _error_overridden;
   bool _ready_to_exit;
+  /// The exit code
+  int _exit_code;
 
   /// This variable indicates when a request has been made to restart from an Exodus file
   bool _initial_from_file;
@@ -1412,7 +1420,7 @@ class MooseApp : public ConsoleStreamInterface,
    * and launches the TestHarness to process the given directory.
    * @return a Boolean value used to indicate whether the application should exit early
    */
-  bool runInputs() const;
+  bool runInputs();
 
   /// General storage for custom RestartableData that can be added to from outside applications
   std::unordered_map<RestartableDataMapName, std::pair<RestartableDataMap, std::string>>

framework/include/base/MooseMain.h

@@ -33,7 +33,7 @@ void addMainCommandLineParams(InputParameters & params);
  * Initialize, create and run a MooseApp
  */
 template <typename DefaultAppType>
-void
+int
 main(int argc, char * argv[])
 {
   MooseInit init(argc, argv);
@@ -45,5 +45,7 @@ main(int argc, char * argv[])
   auto app = createMooseApp(default_app_name, argc, argv);
 
   app->run();
+
+  return app->exitCode();
 }
 }

framework/src/base/MooseApp.C

@@ -403,6 +403,7 @@ MooseApp::MooseApp(InputParameters parameters)
     _factory(*this),
     _error_overridden(false),
     _ready_to_exit(false),
+    _exit_code(0),
     _initial_from_file(false),
     _distributed_mesh_on_command_line(false),
     _recover(false),
@@ -1669,7 +1670,7 @@ MooseApp::copyInputs() const
 }
 
 bool
-MooseApp::runInputs() const
+MooseApp::runInputs()
 {
   if (isParamValid("run"))
   {
@@ -1717,10 +1718,7 @@ MooseApp::runInputs() const
     if (processor_id() == 0)
       return_value = system(cmd.c_str());
     _communicator.broadcast(return_value);
-
-    // TODO: return the actual return value here
-    if (WIFEXITED(return_value) && WEXITSTATUS(return_value) != 0)
-      mooseError("Run failed");
+    _exit_code = return_value;
     return true;
   }
 

modules/chemical_reactions/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ChemicalReactionsTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ChemicalReactionsTestApp>(argc, argv);
 }

modules/combined/src/main.C

@@ -18,7 +18,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<CombinedTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<CombinedTestApp>(argc, argv);
 }

modules/contact/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ContactTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ContactTestApp>(argc, argv);
 }

modules/electromagnetics/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ElectromagneticsTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ElectromagneticsTestApp>(argc, argv);
 }

modules/external_petsc_solver/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<ExternalPetscSolverTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<ExternalPetscSolverTestApp>(argc, argv);
 }

modules/fluid_properties/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<FluidPropertiesTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<FluidPropertiesTestApp>(argc, argv);
 }

modules/fsi/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<FsiTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<FsiTestApp>(argc, argv);
 }

modules/functional_expansion_tools/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<FunctionalExpansionToolsTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<FunctionalExpansionToolsTestApp>(argc, argv);
 }

modules/geochemistry/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<GeochemistryTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<GeochemistryTestApp>(argc, argv);
 }

modules/heat_transfer/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<HeatTransferTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<HeatTransferTestApp>(argc, argv);
 }

modules/level_set/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<LevelSetTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<LevelSetTestApp>(argc, argv);
 }

modules/misc/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<MiscTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<MiscTestApp>(argc, argv);
 }

modules/navier_stokes/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<NavierStokesTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<NavierStokesTestApp>(argc, argv);
 }

modules/optimization/src/main.C

@@ -14,7 +14,5 @@
 int
 main(int argc, char * argv[])
 {
-  Moose::main<OptimizationTestApp>(argc, argv);
-
-  return 0;
+  return Moose::main<OptimizationTestApp>(argc, argv);
 }