fix: remove defineField event args for component compat closes #4637 #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 93 93
Lines 7657 7657
Branches 1348 1348
=======================================
Hits 6876 6876
Misses 774 774
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 26, 2024
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #4637 by removing the event args from handlers created by
defineField, they were not used anyways and they only act as signals for the field to validate or apply meta changes.