Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run initial sync at startup and add verbose flag #4

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

lokijuhy
Copy link
Owner

@lokijuhy lokijuhy commented Jun 22, 2021

New Features:

  • code_sync now runs an initial rsync upon startup before running in watch-for-changes mode, so that changes are synced right away.
  • Added a verbose flag that prints the rsync and watchmedo shell commands for help in debugging.

Bugfixes:

  • Fixes [BUG]: rsync error w/ AppleInternal error #3, where using command line args instead of the project registration did not work (because the port number was set as the local dir)
  • Fixes issue where local dir paths were not expanded, and did not work if contained ~

@lokijuhy lokijuhy requested review from togop and matteobe June 22, 2021 09:44
togop
togop previously approved these changes Jun 22, 2021
Copy link

@togop togop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

@matteobe matteobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me as well

Copy link

@togop togop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep :-)

@lokijuhy lokijuhy merged commit 0b968e7 into master Jun 25, 2021
@lokijuhy lokijuhy deleted the run_initial_sync branch June 25, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: rsync error w/ AppleInternal error
3 participants