Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit and delete config entries #5

Merged
merged 8 commits into from
Sep 13, 2021
Merged

Conversation

lokijuhy
Copy link
Owner

@lokijuhy lokijuhy commented Jul 22, 2021

You can now edit and delete registered code_sync projects via code_sync --edit <project> and code_sync --delete <project>.

@lokijuhy lokijuhy requested a review from arcsi1989 July 22, 2021 17:04
@lokijuhy lokijuhy marked this pull request as ready for review July 27, 2021 14:22
@arcsi1989
Copy link

Looks good.
Would it be possible to directly edit one of the configurations?
e.g. code_sync --edit 'test'?
In case of 10 projects, one has to iterate through all of them?

@lokijuhy
Copy link
Owner Author

lokijuhy commented Sep 1, 2021

Looks good.
Would it be possible to directly edit one of the configurations?
e.g. code_sync --edit 'test'?
In case of 10 projects, one has to iterate through all of them?

Good point! I changed it so that the user specifies code_sync --edit <project> or code_sync --delete <project>

Copy link

@arcsi1989 arcsi1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for making the changes.

@lokijuhy lokijuhy merged commit 2e8d968 into master Sep 13, 2021
@lokijuhy lokijuhy deleted the edit_config branch September 13, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants