-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow returning of CallErrors #225
Allow returning of CallErrors #225
Conversation
Hey and thanks for adding this. It makes a lot of sense to be able to send arbitrary OCPP errors in responses. Your approach is simple and effective so I'd keep it that way. However I believe you are misusing the A cleaner way would be to use the |
Thanks for the input. You are correct, |
A test is now failing at assert.Equal(t, protoErr.MessageId, messageId) // unique id is returned even after invalid type cast error |
Sorry for the long delay, should be fine now |
Based on #219 , this implements the
Error
interface forCallError
and the corresponding type check for sending the error data.This is done rather simple, so please feel free to suggest improvements.