Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stop to CSMS and CentralSystem #245

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

rbright
Copy link
Contributor

@rbright rbright commented Nov 30, 2023

While implementing the server and client in my own application, I realized that only the ChargePoint and ChargingStation interfaces exposed a Stop function. As I'd like for the CentralSystem and CSMS to be capable of graceful shutdown when the application stops, I've exposed Stop on those interfaces as well.

@lorenzodonini
Copy link
Owner

Thanks for contributing! Woud you like to also have a go at writing a simple test for the Stop function? If not, I'll add one at a later point.

@rbright
Copy link
Contributor Author

rbright commented Dec 1, 2023

@lorenzodonini Sure thing, I'll dig into the CSMS and CentralSystem tests a bit further and make some updates here.

@rbright
Copy link
Contributor Author

rbright commented Dec 1, 2023

I replicated the mocking and call assertion style that Start used in both the OCPP 1.6 and 2.0.1 test scenarios.

@lorenzodonini
Copy link
Owner

@rbright thanks a lot for the addition!

@lorenzodonini lorenzodonini merged commit 1bc3b3a into lorenzodonini:master Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants