Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.2 #119

Merged
merged 16 commits into from
Aug 30, 2022
Merged

v1.0.2 #119

merged 16 commits into from
Aug 30, 2022

Conversation

lowlydba
Copy link
Owner

Description

Implement changes requested during the ansible inclusion process: ansible-collections/ansible-inclusion#51

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - Fixes #
  • New feature (non-breaking change which adds functionality)

Checklist:

@github-actions
Copy link

github-actions bot commented Aug 27, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #119 (0580ff0) into main (73b7ca6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          59       59           
  Lines        2002     2002           
  Branches        2        2           
=======================================
  Hits         1883     1883           
  Misses        119      119           
Impacted Files Coverage Δ
plugins/module_utils/_SqlServerUtils.psm1 95.65% <ø> (ø)
plugins/modules/ag_listener.py 100.00% <ø> (ø)
plugins/modules/ag_replica.py 100.00% <ø> (ø)
plugins/modules/agent_job.py 100.00% <ø> (ø)
plugins/modules/agent_job_category.py 100.00% <ø> (ø)
plugins/modules/agent_job_schedule.py 100.00% <ø> (ø)
plugins/modules/agent_job_step.py 100.00% <ø> (ø)
plugins/modules/availability_group.py 100.00% <ø> (ø)
plugins/modules/backup.py 100.00% <ø> (ø)
plugins/modules/database.py 100.00% <ø> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@briantist
Copy link
Collaborator

Thanks! I can take a look later on and review

Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these suggested changes are nits and small things. Many are suggestions/opinionated, so don't feel that you must accept them.

You can commit suggestions in batches by looking at them from the Files view in the PR and selecting "add to batch" so that they don't cause individual commits for each one (which would kill the CI 😅).


Additional suggestion (non-blocking, can be backlogged): none of the modules' documentation use a seealso: section, but there are many related modules here. For example, the agent_job* modules should probably link to each other.

Search for seealso in this page to see the format; it's very easy to use.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
plugins/modules/ag_listener.py Outdated Show resolved Hide resolved
plugins/modules/ag_replica.py Outdated Show resolved Hide resolved
plugins/modules/agent_job_category.py Outdated Show resolved Hide resolved
plugins/modules/restore.py Outdated Show resolved Hide resolved
plugins/modules/restore.py Outdated Show resolved Hide resolved
plugins/modules/sp_configure.py Outdated Show resolved Hide resolved
plugins/modules/sp_whoisactive.py Outdated Show resolved Hide resolved
plugins/modules/spn.py Outdated Show resolved Hide resolved
lowlydba and others added 4 commits August 28, 2022 15:52
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
@briantist
Copy link
Collaborator

I can suggest a change real quick for that sanity failure

lowlydba and others added 2 commits August 28, 2022 16:21
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changelog update is the last thing I have, I went back over it against the inclusion checklist and everything else looks great, so with the changelog update, I think we'll be done! (there's one other conversation I unresolved for clarity, but it's optional)

changelogs/fragments/119-doc-updates.yml Outdated Show resolved Hide resolved
lowlydba and others added 2 commits August 29, 2022 20:39
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
@lowlydba
Copy link
Owner Author

This changelog update is the last thing I have, I went back over it against the inclusion checklist and everything else looks great, so with the changelog update, I think we'll be done! (there's one other conversation I unresolved for clarity, but it's optional)

Thanks! Yeah that other one was a mistake to resolve and then it got lost - thanks for re-surfacing!

@lowlydba lowlydba merged commit f2d6730 into main Aug 30, 2022
@lowlydba lowlydba deleted the 1-0-2 branch November 29, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants