-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.2 #119
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 59 59
Lines 2002 2002
Branches 2 2
=======================================
Hits 1883 1883
Misses 119 119
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks! I can take a look later on and review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these suggested changes are nits and small things. Many are suggestions/opinionated, so don't feel that you must accept them.
You can commit suggestions in batches by looking at them from the Files view in the PR and selecting "add to batch" so that they don't cause individual commits for each one (which would kill the CI 😅).
Additional suggestion (non-blocking, can be backlogged): none of the modules' documentation use a seealso:
section, but there are many related modules here. For example, the agent_job*
modules should probably link to each other.
Search for seealso
in this page to see the format; it's very easy to use.
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
I can suggest a change real quick for that sanity failure |
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changelog update is the last thing I have, I went back over it against the inclusion checklist and everything else looks great, so with the changelog update, I think we'll be done! (there's one other conversation I unresolved for clarity, but it's optional)
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Co-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>
Thanks! Yeah that other one was a mistake to resolve and then it got lost - thanks for re-surfacing! |
Description
Implement changes requested during the ansible inclusion process: ansible-collections/ansible-inclusion#51
How Has This Been Tested?
Types of changes
Checklist:
version_added
property.