-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: sql mi fixes #153
Fix: sql mi fixes #153
Conversation
- remove useDestinationDefaultDirectories default - remove KeepCDC default - add mapping for useDestinationDefaultDirectories
- remove default for UseDestinationDefaultDirectories - remove default for KeepCDC
Docs Build 📝Thank you for contribution!✨ The docs for this PR have been published here: You can compare to the docs for the The docsite for this PR is also available for download as an artifact from this run: File changes: Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html
index 5eddaf0..a313a2f 100644
--- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html
+++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html
@@ -283,7 +283,7 @@ see <a class="reference internal" href="#ansible-collections-lowlydba-sqlserver-
<td><div class="ansible-option-cell"><p>Indicates whether CDC information should be restored as part of the database.</p>
<p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
<ul class="simple">
-<li><p><code class="ansible-option-default-bold docutils literal notranslate"><span class="pre">false</span></code> <span class="ansible-option-choices-default-mark">← (default)</span></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">true</span></code></p></li>
</ul>
</div></td>
@@ -456,7 +456,7 @@ see <a class="reference internal" href="#ansible-collections-lowlydba-sqlserver-
<p>If they don’t exist, the function will try to create them.</p>
<p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
<ul class="simple">
-<li><p><code class="ansible-option-default-bold docutils literal notranslate"><span class="pre">false</span></code> <span class="ansible-option-choices-default-mark">← (default)</span></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">true</span></code></p></li>
</ul>
</div></td>
|
I found 2 more unsupported parameters when I tested with PowerShell. And while I was fixing those I noticed that UseDestinationDefaultDirectories was never mapped to a parameter. |
Codecov ReportBase: 93.94% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
===========================================
+ Coverage 93.94% 100.00% +6.05%
===========================================
Files 62 32 -30
Lines 2114 103 -2011
===========================================
- Hits 1986 103 -1883
+ Misses 128 0 -128 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Awesome work! Thanks so much for the continued contributions. I hope the rest of the module defaults perform more smoothly for MI :) |
Description
Removed the default option for UseDestinationDefaultDirectories and KeepCDC to allow for compatibility with Azure SQL MI. Added missing mapping for UseDestinationDefaultDirectories.
How Has This Been Tested?
Manually using the Restore-DbaDatabase PowerShell command.
Types of changes
Checklist:
version_added
property.