Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sql mi fixes #153

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Fix: sql mi fixes #153

merged 5 commits into from
Dec 6, 2022

Conversation

jkrilov
Copy link
Contributor

@jkrilov jkrilov commented Dec 6, 2022

Description

Removed the default option for UseDestinationDefaultDirectories and KeepCDC to allow for compatibility with Azure SQL MI. Added missing mapping for UseDestinationDefaultDirectories.

How Has This Been Tested?

Manually using the Restore-DbaDatabase PowerShell command.

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - Fixes #
  • New feature (non-breaking change which adds functionality)

Checklist:

- remove useDestinationDefaultDirectories default
- remove KeepCDC default
- add mapping for useDestinationDefaultDirectories
- remove default for UseDestinationDefaultDirectories 
- remove default for KeepCDC
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Docs Build 📝

Thank you for contribution!✨

The docs for this PR have been published here:
https://lowlydba.github.io/lowlydba.sqlserver/pr/153

You can compare to the docs for the main branch here:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main

The docsite for this PR is also available for download as an artifact from this run:
https://github.com/lowlydba/lowlydba.sqlserver/actions/runs/3630176627

File changes:

Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html
index 5eddaf0..a313a2f 100644
--- a/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/base/collections/lowlydba/sqlserver/restore_module.html
+++ b/home/runner/work/lowlydba.sqlserver/lowlydba.sqlserver/docsbuild/head/collections/lowlydba/sqlserver/restore_module.html
@@ -283,7 +283,7 @@ see <a class="reference internal" href="#ansible-collections-lowlydba-sqlserver-
 <td><div class="ansible-option-cell"><p>Indicates whether CDC information should be restored as part of the database.</p>
 <p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
 <ul class="simple">
-<li><p><code class="ansible-option-default-bold docutils literal notranslate"><span class="pre">false</span></code> <span class="ansible-option-choices-default-mark">← (default)</span></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">true</span></code></p></li>
 </ul>
 </div></td>
@@ -456,7 +456,7 @@ see <a class="reference internal" href="#ansible-collections-lowlydba-sqlserver-
 <p>If they don’t exist, the function will try to create them.</p>
 <p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
 <ul class="simple">
-<li><p><code class="ansible-option-default-bold docutils literal notranslate"><span class="pre">false</span></code> <span class="ansible-option-choices-default-mark">← (default)</span></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">false</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">true</span></code></p></li>
 </ul>
 </div></td>

@jkrilov
Copy link
Contributor Author

jkrilov commented Dec 6, 2022

I found 2 more unsupported parameters when I tested with PowerShell. And while I was fixing those I noticed that UseDestinationDefaultDirectories was never mapped to a parameter.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 93.94% // Head: 100.00% // Increases project coverage by +6.05% 🎉

Coverage data is based on head (67cd453) compared to base (310bff5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #153      +/-   ##
===========================================
+ Coverage   93.94%   100.00%   +6.05%     
===========================================
  Files          62        32      -30     
  Lines        2114       103    -2011     
===========================================
- Hits         1986       103    -1883     
+ Misses        128         0     -128     
Impacted Files Coverage Δ
plugins/modules/restore.py 100.00% <ø> (ø)
plugins/modules/restore.ps1
plugins/modules/install_script.ps1
plugins/modules/dba_multitool.ps1
plugins/modules/backup.ps1
plugins/modules/spn.ps1
plugins/module_utils/_SqlServerUtils.psm1
plugins/modules/memory.ps1
plugins/modules/rg_resource_pool.ps1
plugins/modules/traceflag.ps1
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkrilov jkrilov changed the title Fix/sql mi fixes Fix: sql mi fixes Dec 6, 2022
@lowlydba
Copy link
Owner

lowlydba commented Dec 6, 2022

Awesome work! Thanks so much for the continued contributions. I hope the rest of the module defaults perform more smoothly for MI :)

@lowlydba lowlydba merged commit 6fac1a6 into lowlydba:main Dec 6, 2022
@jkrilov jkrilov deleted the fix/sql_mi_fixes branch December 6, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants