-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ImageMagick dependency #75
Conversation
Fantastic, I knew there'd be a way to do this without an external tool just never got around to looking into it. I'll test out the changes tonight 👍 |
Sure. I'll list out one issue I found. It seems to print an extra black/white line at the bottom of the image in rare cases. I'll have to dig deeper into that. |
Gave it a try and it works pretty well, much faster compared to imagemagick. I did notice that issue you were talking about, but for me it's actually on every image, the bottom row of pixels is all white. Also, winfetch doesn't appear to work at all in PSv5, I get the following error,
|
Wait, that's weird, I do all my testing on PSv5. I don't even have Core installed 😅 Can you try replacing Edit: |
Indeed replacing that character with I've also figured out what the issue was with the white line, basically the character your using To fix that you need to rewrite your logic to use |
I made the change. Let me know if it works. |
Yep tested and it's working fine. |
This PR introduces substantial quality improvements, with very little code change.
Highlights: