Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Translate programming language names #9279

Merged

Conversation

magaupp
Copy link
Contributor

@magaupp magaupp commented Sep 4, 2024

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

The displayed options of the programming languages in the exercise creation dialog are generated from the ProgrammingLanguage enum member names. This does not always provide human readable names and proper capitalization.

Description

I use the previously used translation values and extended them by all currently defined enum members.

Further, the Empty template is renamed to Other to signify its use as a starting point for non-provided languages.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course
  1. Log in to Artemis
  2. Navigate to the exercise creation dialog
  3. Click on the Programming Language selection box
  4. Verify that all programming languages are properly capitalized

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Test Coverage

Screenshots

Current:
grafik

Translated:
grafik

Summary by CodeRabbit

  • New Features

    • Enhanced dropdown for programming languages now supports dynamic translations based on user locale.
    • Expanded list of programming languages available in both German and English localization files, improving user experience for multilingual users.
  • Bug Fixes

    • Updated "EMPTY" entry to "Other" in localization files for better clarity.
  • Documentation

    • Improved internationalization support through streamlined language representation in the UI.

@magaupp magaupp self-assigned this Sep 4, 2024
@magaupp magaupp requested a review from a team as a code owner September 4, 2024 11:38
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 4, 2024
Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

The changes involve updates to the programming language selection in a web application. The dropdown for programming languages has been modified to utilize a translation mechanism for internationalization, replacing manual string formatting. Additionally, the localization files for German and English have been expanded to include a wider range of programming languages, enhancing the application's support for multiple languages.

Changes

File Path Change Summary
src/main/webapp/app/exercises/programming/manage/update/update-components/programming-exercise-language.component.html Updated dropdown to use translation keys for programming languages instead of manual formatting.
src/main/webapp/i18n/de/programmingLanguage.json Expanded list of programming languages and modified "EMPTY" entry to "Andere" (Other).
src/main/webapp/i18n/en/programmingLanguage.json Expanded list of programming languages and modified "EMPTY" entry to "Other."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Contributor

@undernagruzez undernagruzez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) ready to merge small
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants