Development: Migrate admin metrics Angular code to new best practices

[krusche]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
• I strictly followed the principle of data economy for all client-server REST calls.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I documented the TypeScript code using JSDoc style.

Motivation and Context

This should become an example how modern Angular code with input(), output(), signal() and inject() can look like

Steps for Testing

Prerequisites:

• 1 Admin

1. Open the metrics page and make sure it works properly and displays correct data

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Summary by CodeRabbit

• New Features

  • Introduced a new dependency, ngxtension, enhancing application capabilities.
  • Transitioned multiple components to standalone architecture for improved modularity.

• Enhancements

  • Updated input properties across several components to enforce required values, improving type safety.
  • Improved performance with ChangeDetectionStrategy.OnPush in various components.
  • Enhanced test setup for JvmThreadsComponent and MetricsModalThreadsComponent with asynchronous operations and improved input handling.

• Bug Fixes

  • Adjusted access patterns for metrics properties from direct access to function calls, enhancing data responsiveness.

• Tests

  • Enhanced test coverage for MetricsComponent with additional mocks and HTTP client testing setup.
  • Improved tests for JvmThreadsComponent and MetricsModalThreadsComponent to align with Angular best practices.

• Chores

  • Cleaned up formatting in tsconfig.json for better readability.

[coderabbitai]

Walkthrough

The changes encompass updates to the Angular application, including the introduction of a new dependency in package.json, modifications to various components to adopt a standalone architecture, and the transition to function calls for accessing metrics data. Additionally, the service and model files have been refined to enhance type safety and streamline property definitions. The test suite for the JvmThreadsComponent and MetricsModalThreadsComponent has been updated to improve asynchronous handling and input property management. Overall, the updates reflect a shift towards modern Angular practices, improving modularity and maintainability.

Changes

Files	Change Summary
package.json	Added ngxtension dependency.
src/main/webapp/app/admin/*.ts	Transitioned components to standalone architecture and updated input properties to use input().
src/main/webapp/app/admin/*.html	Changed property accesses to function calls for metrics data retrieval.
src/main/webapp/app/admin/metrics.model.ts	Modified HttpMethod enum and updated interface properties from nullable to optional types.
src/main/webapp/app/admin/metrics.service.ts	Refactored dependency injection to use inject() instead of constructor-based injection.
src/test/javascript/spec/component/admin/metrics/*.spec.ts	Enhanced test suite with component mocks and improved asynchronous handling in JvmThreadsComponent and MetricsModalThreadsComponent.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MetricsComponent
    participant MetricsService
    participant MetricsData

    User->>MetricsComponent: Initialize Component
    MetricsComponent->>MetricsService: Call getMetrics()
    MetricsService->>MetricsData: Fetch Metrics Data
    MetricsData-->>MetricsService: Return Metrics Data
    MetricsService-->>MetricsComponent: Return Metrics Data
    MetricsComponent->>User: Display Metrics

Loading

Possibly related issues

• Replace deprecated HttpClientTestingModule with new providers provideHttpClient()and provideHttpClientTesting() #9052: The changes replace the deprecated HttpClientTestingModule with provideHttpClient() and provideHttpClientTesting(), addressing the issue's objective to update the testing setup accordingly.

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Outside diff range comments (1)

src/main/webapp/app/admin/metrics/blocks/metrics-garbagecollector/metrics-garbagecollector.component.html (1)

Line range hint 53-79: Optimize repeated function calls and confirm correct function usage.

The function garbageCollectorMetrics() is called multiple times for different properties. Consider using a local variable to store the results. Additionally, the update to updating() as a function call is correctly implemented.

[SimonEntholzer]

For some reason deploying to test servers is broken again here, but the page works fine locally

edit: it's because there are merge conflicts

[undernagruzez]

works locally

[BBesrour]

demonstrated in a testing session, lgtm