Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse ary and new_ary types in call-seq #1104

Merged
merged 1 commit into from
Aug 7, 2017
Merged

Parse ary and new_ary types in call-seq #1104

merged 1 commit into from
Aug 7, 2017

Conversation

ypresto
Copy link
Contributor

@ypresto ypresto commented Jul 17, 2017

Description

Lastest Ruby's array.c contains ary and new_ary return types which is not handled by yard for now. So @return for Array#map is missing from generated yard doc. This PR fixes it..!

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@coveralls
Copy link

coveralls commented Jul 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 93.496% when pulling f5a500d on ypresto:new_ary into 3374f8c on lsegal:master.

@lsegal
Copy link
Owner

lsegal commented Jul 18, 2017

This seems to fail tests on the &. syntax, which we can't use.

@ypresto
Copy link
Contributor Author

ypresto commented Jul 19, 2017 •
edited
Loading

Oh, I'll fix it!

@ypresto
Copy link
Contributor Author

ypresto commented Jul 19, 2017

fixed!

@coveralls
Copy link

coveralls commented Jul 19, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 93.508% when pulling a4af5e1 on ypresto:new_ary into 3374f8c on lsegal:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.508% when pulling a4af5e1 on ypresto:new_ary into 3374f8c on lsegal:master.

@lsegal lsegal merged commit 1172b1d into lsegal:master Aug 7, 2017
@lsegal
Copy link
Owner

lsegal commented Aug 7, 2017

Thanks for the PR!

@ypresto ypresto deleted the new_ary branch August 17, 2017 14:06
lsegal added a commit that referenced this pull request Nov 18, 2017
@lsegal
Tag release v0.9.10
9fcfe09 
References:
  #1023, #1077, #1079, #1089, #1093, #1097, #1099, #1101,
  #1102, #1104, #1111, #1119, #1123, #1124, #1126, #1128,
  #1133, #1135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ypresto @coveralls @lsegal