Skip to content

Commit

Permalink
Remove obsolete substitution for kafka snappy
Browse files Browse the repository at this point in the history
    Kafka 2.8.0 removes the `MethodHandle` usage in `CompressionType` (see
    apache/kafka#10123) removing
    `SnappyConstructors` as well.  As a result the substitution is no
    longer valid.

    The update to Kafka 2.8.0 was done in
    quarkusio/quarkus@f8ce993

    Fixes #16721
  • Loading branch information
Luca Di Grazia committed Sep 4, 2022
1 parent 8a0143d commit 1a0fe15
Showing 1 changed file with 7 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import static org.apache.kafka.common.record.CompressionType.GZIP;
import static org.apache.kafka.common.record.CompressionType.NONE;

import java.lang.invoke.MethodHandle;
import java.util.List;
import java.util.Map;
import java.util.function.BooleanSupplier;

import org.apache.kafka.common.metrics.JmxReporter;
Expand All @@ -14,8 +14,6 @@
import org.apache.kafka.common.utils.AppInfoParser;
import org.graalvm.home.Version;

import com.oracle.svm.core.annotate.Alias;
import com.oracle.svm.core.annotate.RecomputeFieldValue;
import com.oracle.svm.core.annotate.Substitute;
import com.oracle.svm.core.annotate.TargetClass;

Expand All @@ -25,19 +23,6 @@
* * Remove JMX
*/

@TargetClass(value = CompressionType.class, innerClass = "SnappyConstructors", onlyWith = GraalVM20OrEarlier.class)
final class SubstituteSnappy {

@Alias
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.Reset)
static MethodHandle INPUT = null;

@Alias
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.Reset)
static MethodHandle OUTPUT = null;

}

final class GraalVM20OrEarlier implements BooleanSupplier {

@Override
Expand All @@ -47,7 +32,7 @@ public boolean getAsBoolean() {
}

@TargetClass(value = CompressionType.class, onlyWith = GraalVM20OrEarlier.class)
final class FixEnumAccess {
final class SubstituteSnappy {

@Substitute
public static CompressionType forName(String name) {
Expand Down Expand Up @@ -91,6 +76,11 @@ public static synchronized void unregisterAppInfo(String prefix, String id, Metr
@TargetClass(value = JmxReporter.class)
final class JMXReporting {

@Substitute
public void reconfigure(Map<String, ?> configs) {

}

@Substitute
public void init(List<KafkaMetric> metrics) {

Expand Down

0 comments on commit 1a0fe15

Please sign in to comment.