Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icons): changed milestone icon #2281

Merged
merged 16 commits into from
Aug 23, 2024
Merged

fix(icons): changed milestone icon #2281

merged 16 commits into from
Aug 23, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Jul 3, 2024

What is the purpose of this pull request?

  • Other: Icon update

Description

Arcified icon.

Before Submitting

@github-actions github-actions bot added the 🎨 icon About new icons label Jul 3, 2024
@github-actions github-actions bot added the 🫧 metadata Improved metadata label Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

Added or changed icons

icons/milestone.svgicons/signpost.svg

Preview cohesion icons/message-square-dot.svgicons/square-stack.svg
icons/milestone.svgicons/signpost.svg
icons/tower-control.svgicons/box.svg
Preview stroke widths icons/milestone.svgicons/signpost.svg
icons/milestone.svgicons/signpost.svg
icons/milestone.svgicons/signpost.svg
DPI Preview (24px) icons/milestone.svg icons/signpost.svg
Icon X-rays icons/milestone.svg icons/signpost.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const MilestoneIcon = createLucideIcon('Milestone', [
  ["path",{"d":"M12 13v8"}],
  ["path",{"d":"M12 3v3"}],
  ["path",{"d":"M4 6a1 1 0 0 0-1 1v5a1 1 0 0 0 1 1h13a2 2 0 0 0 1.152-.365l3.424-2.317a1 1 0 0 0 0-1.635l-3.424-2.318A2 2 0 0 0 17 6z"}]
])

const SignpostIcon = createLucideIcon('Signpost', [
  ["path",{"d":"M12 13v8"}],
  ["path",{"d":"M12 3v3"}],
  ["path",{"d":"M18 6a2 2 0 0 1 1.387.56l2.307 2.22a1 1 0 0 1 0 1.44l-2.307 2.22A2 2 0 0 1 18 13H6a2 2 0 0 1-1.387-.56l-2.306-2.22a1 1 0 0 1 0-1.44l2.306-2.22A2 2 0 0 1 6 6z"}]
])

karsa-mistmere
karsa-mistmere requested changes Jul 4, 2024
View reviewed changes
icons/milestone.svg Outdated Show resolved Hide resolved
karsa-mistmere
karsa-mistmere requested changes Jul 4, 2024
View reviewed changes
icons/milestone.svg Show resolved Hide resolved
@jguddas @karsa-mistmere
Update icons/milestone.svg
8b7d40f 
Co-authored-by: Karsa <contact@karsa.org>
@ericfennis
Copy link
Member

@karsa-mistmere Can you check if this right now?

@karsa-mistmere karsa-mistmere merged commit 0160bbe into lucide-icons:main Aug 23, 2024
7 of 8 checks passed
@yunji0387 yunji0387 mentioned this pull request Sep 15, 2024
Open
@thatguyinabeanie thatguyinabeanie mentioned this pull request Sep 15, 2024
Merged
This was referenced Sep 15, 2024
Open
Open
This was referenced Sep 16, 2024
Merged
Merged
Merged
@stilt0n stilt0n mentioned this pull request Sep 16, 2024
Open
@AntonyJudeShaman AntonyJudeShaman mentioned this pull request Sep 16, 2024
Open
@carltrepanier carltrepanier mentioned this pull request Sep 16, 2024
Merged
@0plan 0plan mentioned this pull request Sep 16, 2024
Open
@nslee333 nslee333 mentioned this pull request Sep 16, 2024
Merged
@ezaz-ahmed ezaz-ahmed mentioned this pull request Sep 16, 2024
Open
@AlbertChambers AlbertChambers mentioned this pull request Sep 16, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 16, 2024
Open
@stilt0n stilt0n mentioned this pull request Sep 17, 2024
Open
@AlbertChambers AlbertChambers mentioned this pull request Sep 17, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 17, 2024
Open
@ezaz-ahmed ezaz-ahmed mentioned this pull request Sep 18, 2024
Open
@waveyboym waveyboym mentioned this pull request Sep 18, 2024
Open
sanchitrk added a commit to zyghq/zyg that referenced this pull request Sep 18, 2024
@sanchitrk
[Snyk] Upgrade lucide-react from 0.379.0 to 0.435.0 (#41)
664e386 
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)


<h3>Snyk has created this PR to upgrade lucide-react from 0.379.0 to
0.435.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **50 versions** ahead of your current
version.

- The recommended version was released on **21 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>lucide-react</b></summary>
    <ul>
      <li>
<b>0.435.0</b> - <a
href="https://github.com/lucide-icons/lucide/releases/tag/0.435.0">2024-08-23</a></br><h2>Modified
Icons 🔨</h2>
<ul>
<li><code>milestone</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2389170587"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2281"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2281/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2281">#2281</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jguddas/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/jguddas">@ jguddas</a></li>
<li><code>signpost</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2389170587"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2281"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2281/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2281">#2281</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jguddas/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/jguddas">@ jguddas</a></li>
</ul>
      </li>
      <li>
<b>0.434.0</b> - <a
href="https://github.com/lucide-icons/lucide/releases/tag/0.434.0">2024-08-23</a></br><h2>New
icons 🎨</h2>
<ul>
<li><code>volume-off</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
</ul>
<h2>Modified Icons 🔨</h2>
<ul>
<li><code>file-volume</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
<li><code>volume-1</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
<li><code>volume-2</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
<li><code>volume-x</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
<li><code>volume</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2470475482"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2378"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2378/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2378">#2378</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/karsa-mistmere/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/karsa-mistmere">@ karsa-mistmere</a></li>
</ul>
      </li>
      <li>
<b>0.433.0</b> - <a
href="https://github.com/lucide-icons/lucide/releases/tag/0.433.0">2024-08-23</a></br><h2>New
icons 🎨</h2>
<ul>
<li><code>trending-up-down</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2467900248"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2372"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2372/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2372">#2372</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/Alportan/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/Alportan">@ Alportan</a></li>
</ul>
<h2>Fixes Lucide Solid</h2>
<ul>
<li>Fixed compilation issues when starting up Vite Dev server by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ericfennis/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/ericfennis">@ ericfennis</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2470215746" data-permission-text="Title is private"
data-url="lucide-icons/lucide#2375"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2375/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2375">#2375</a></li>
</ul>
      </li>
      <li>
<b>0.432.0</b> - <a
href="https://github.com/lucide-icons/lucide/releases/tag/0.432.0">2024-08-23</a></br><h2>New
icons 🎨</h2>
<ul>
<li><code>chart-gantt</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2472141724"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2392"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2392/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2392">#2392</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jguddas/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/jguddas">@ jguddas</a></li>
</ul>
<h2>Modified Icons 🔨</h2>
<ul>
<li><code>contact-round</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2472125869"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2391"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2391/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2391">#2391</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jguddas/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/jguddas">@ jguddas</a></li>
<li><code>contact</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2472125869"
data-permission-text="Title is private"
data-url="lucide-icons/lucide#2391"
data-hovercard-type="pull_request"
data-hovercard-url="/lucide-icons/lucide/pull/2391/hovercard"
href="https://github.com/lucide-icons/lucide/pull/2391">#2391</a>) by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/jguddas/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/jguddas">@ jguddas</a></li>
</ul>
      </li>
      <li>
        <b>0.429.0</b> - 2024-08-21
      </li>
      <li>
        <b>0.428.0</b> - 2024-08-16
      </li>
      <li>
        <b>0.427.0</b> - 2024-08-09
      </li>
      <li>
        <b>0.426.0</b> - 2024-08-08
      </li>
      <li>
        <b>0.425.0</b> - 2024-08-08
      </li>
      <li>
        <b>0.424.0</b> - 2024-08-02
      </li>
      <li>
        <b>0.423.0</b> - 2024-08-02
      </li>
      <li>
        <b>0.422.0</b> - 2024-08-02
      </li>
      <li>
        <b>0.421.0</b> - 2024-08-02
      </li>
      <li>
        <b>0.420.0</b> - 2024-08-02
      </li>
      <li>
        <b>0.419.0</b> - 2024-08-01
      </li>
      <li>
        <b>0.418.0</b> - 2024-07-31
      </li>
      <li>
        <b>0.417.0</b> - 2024-07-28
      </li>
      <li>
        <b>0.416.0</b> - 2024-07-25
      </li>
      <li>
        <b>0.415.0</b> - 2024-07-25
      </li>
      <li>
        <b>0.414.0</b> - 2024-07-22
      </li>
      <li>
        <b>0.413.0</b> - 2024-07-22
      </li>
      <li>
        <b>0.412.0</b> - 2024-07-20
      </li>
      <li>
        <b>0.411.0</b> - 2024-07-19
      </li>
      <li>
        <b>0.410.0</b> - 2024-07-19
      </li>
      <li>
        <b>0.409.0</b> - 2024-07-19
      </li>
      <li>
        <b>0.408.0</b> - 2024-07-12
      </li>
      <li>
        <b>0.407.0</b> - 2024-07-09
      </li>
      <li>
        <b>0.406.0</b> - 2024-07-09
      </li>
      <li>
        <b>0.405.0</b> - 2024-07-09
      </li>
      <li>
        <b>0.404.0</b> - 2024-07-09
      </li>
      <li>
        <b>0.403.0</b> - 2024-07-08
      </li>
      <li>
        <b>0.402.0</b> - 2024-07-08
      </li>
      <li>
        <b>0.401.0</b> - 2024-07-07
      </li>
      <li>
        <b>0.400.0</b> - 2024-07-01
      </li>
      <li>
        <b>0.399.0</b> - 2024-06-28
      </li>
      <li>
        <b>0.398.0</b> - 2024-06-28
      </li>
      <li>
        <b>0.397.0</b> - 2024-06-26
      </li>
      <li>
        <b>0.396.0</b> - 2024-06-21
      </li>
      <li>
        <b>0.395.0</b> - 2024-06-14
      </li>
      <li>
        <b>0.394.0</b> - 2024-06-10
      </li>
      <li>
        <b>0.391.0</b> - 2024-06-10
      </li>
      <li>
        <b>0.390.0</b> - 2024-06-06
      </li>
      <li>
        <b>0.387.0</b> - 2024-06-06
      </li>
      <li>
        <b>0.386.0</b> - 2024-06-06
      </li>
      <li>
        <b>0.385.0</b> - 2024-06-06
      </li>
      <li>
        <b>0.384.0</b> - 2024-06-06
      </li>
      <li>
        <b>0.383.0</b> - 2024-06-02
      </li>
      <li>
        <b>0.382.0</b> - 2024-06-02
      </li>
      <li>
        <b>0.381.0</b> - 2024-05-30
      </li>
      <li>
        <b>0.380.0</b> - 2024-05-30
      </li>
      <li>
        <b>0.379.0</b> - 2024-05-21
      </li>
    </ul>
from <a
href="https://github.com/lucide-icons/lucide/releases">lucide-react
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI5YWMzODA0MS1hMGJmLTQ0ODgtYTk0NC04MDkxZjZlZDk0YTUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjlhYzM4MDQxLWEwYmYtNDQ4OC1hOTQ0LTgwOTFmNmVkOTRhNSJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7/settings/integration?pkg&#x3D;lucide-react&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"lucide-react","from":"0.379.0","to":"0.435.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"9ac38041-a0bf-4488-a944-8091f6ed94a5","prPublicId":"9ac38041-a0bf-4488-a944-8091f6ed94a5","packageManager":"npm","priorityScoreList":[],"projectPublicId":"9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7","projectUrl":"https://app.snyk.io/org/sanchitrk/project/9a9f7a5d-de7e-4f88-93a2-a4ae7546f8c7?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":50,"publishedDate":"2024-08-23T09:34:04.739Z"},"vulns":[]}'
@Kevin-Umali Kevin-Umali mentioned this pull request Sep 18, 2024
Merged
@vigneshshettyin vigneshshettyin mentioned this pull request Sep 18, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 19, 2024
Open
@samurato samurato mentioned this pull request Sep 19, 2024
Open
@sanchitrk sanchitrk mentioned this pull request Sep 19, 2024
Merged
@ShivajiKS ShivajiKS mentioned this pull request Sep 20, 2024
Open
@GouravNG GouravNG mentioned this pull request Sep 20, 2024
Merged
@jdnielss jdnielss mentioned this pull request Sep 20, 2024
Open
@AlbertChambers AlbertChambers mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericfennis ericfennis ericfennis approved these changes

@karsa-mistmere karsa-mistmere Awaiting requested review from karsa-mistmere

Assignees
No one assigned
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jguddas @ericfennis @karsa-mistmere