Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): changed hand and pointer icons #2480

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jamiemlaw
Copy link

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other: icon update

Description

This PR proposes a new series of hand icons, with a more slender and expressive shape, at the cost of a finger.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Sep 19, 2024
Copy link

Added or changed icons

icons/grab.svgicons/hand-metal.svgicons/hand.svgicons/pointer-off.svgicons/pointer.svg

Preview cohesion icons/square-arrow-down-right.svgicons/square-pi.svgicons/square.svgicons/message-square-dashed.svgicons/square-minus.svg
icons/grab.svgicons/hand-metal.svgicons/hand.svgicons/pointer-off.svgicons/pointer.svg
icons/book-audio.svgicons/folder-cog.svgicons/file-input.svgicons/clipboard-x.svgicons/image-down.svg
Preview stroke widths icons/grab.svgicons/hand-metal.svgicons/hand.svgicons/pointer-off.svgicons/pointer.svg
icons/grab.svgicons/hand-metal.svgicons/hand.svgicons/pointer-off.svgicons/pointer.svg
icons/grab.svgicons/hand-metal.svgicons/hand.svgicons/pointer-off.svgicons/pointer.svg
DPI Preview (24px) icons/grab.svg icons/hand-metal.svg icons/hand.svg icons/pointer-off.svg icons/pointer.svg
Icon X-rays icons/grab.svg icons/hand-metal.svg icons/hand.svg icons/pointer-off.svg icons/pointer.svg
Icon Diffs icons/grab.svg icons/hand-metal.svg icons/hand.svg icons/pointer-off.svg icons/pointer.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const GrabIcon = createLucideIcon('Grab', [
  ["path",{"d":"M12 10V9a2 2 0 0 1 4 0v2a2 2 0 0 1 4 0v5a6 6 0 0 1-6 6h-4a6 6 0 0 1-6-6v-1a3 3 0 0 1 3-3h1"}],
  ["path",{"d":"M8 15V9a2 2 0 0 1 4 0"}]
])

const HandMetalIcon = createLucideIcon('HandMetal', [
  ["path",{"d":"M16 11a2 2 0 0 0-4 0V5a2 2 0 0 0-4 0v9.667L6.6 12.8a2 2 0 0 0-3.2 2.4l2.7 3.6a8 8 0 0 0 6.4 3.2H14a6 6 0 0 0 6-6V7a2 2 0 0 0-4 0v5"}]
])

const HandIcon = createLucideIcon('Hand', [
  ["path",{"d":"M12 10V4a2 2 0 0 1 4 0v7"}],
  ["path",{"d":"M16 7a2 2 0 0 1 4 0v9a6 6 0 0 1-6 6h-1.51a8 8 0 0 1-6.4-3.2L3.4 15.2a2 2 0 0 1 3.2-2.4L8 14.672V5a2 2 0 0 1 4 0"}]
])

const PointerOffIcon = createLucideIcon('PointerOff', [
  ["path",{"d":"M16.081 10.433A2.001 2.001 0 0 1 20 11v3.35"}],
  ["path",{"d":"M19.122 19.126A6 6 0 0 1 14 22h-1.5a8 8 0 0 1-6.4-3.2l-2.7-3.6a2 2 0 1 1 3.2-2.4L8 14.667V8"}],
  ["path",{"d":"m2 2 20 20"}],
  ["path",{"d":"M8.423 2.77A2 2 0 0 1 12 4v2.348q.542.545.95.95A2 2 0 0 1 16 9v1.357"}]
])

const PointerIcon = createLucideIcon('Pointer', [
  ["path",{"d":"M12 9a2 2 0 0 1 4 0v2a2 2 0 0 1 4 0v5a6 6 0 0 1-6 6h-1.5a8 8 0 0 1-6.4-3.2l-2.7-3.6a2 2 0 0 1 3.2-2.4L8 14.667V4a2 2 0 0 1 4 0v6"}]
])

@karsa-mistmere
Copy link
Member

As stated in #2344, I'm not really into these changes.

@jamiemlaw
Copy link
Author

As stated in #2344, I'm not really into these changes.

Completely fine. I'll leave it between you and @jguddas to battle it out! 😬

@jamiemlaw jamiemlaw changed the title Update hand and pointer icons fix(icons): Update hand and pointer icons Sep 19, 2024
@jamiemlaw jamiemlaw changed the title fix(icons): Update hand and pointer icons fix(icons): changed hand and pointer icons Sep 19, 2024
@karsa-mistmere
Copy link
Member

Completely fine. I'll leave it between you and @jguddas to battle it out! 😬

Let's also not forget that @ericfennis has the deciding vote here.

My case is: there is hardly any precedent of four fingered hand icons, as for hand emojis, there isn't a single design that uses four fingers.

Switching to these will make any future icons that rely on pinky, ring or middle fingers almost completely unfeasible — hand-metal is a good example, it's just not recognisable for what it is anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants