This repository has been archived by the owner on Sep 30, 2019. It is now read-only.
Move to Node 8 / npm 5, update packages and cleanup #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsaarinen
suggested changes
Jun 9, 2017
package.json
Outdated
| "aws-sdk": "^2.45.0", | ||
| "bluebird": "^3.5.0", | ||
| "boom": "^4.3.1", | ||
| "auth0-js": "^8.7.0", |
There was a problem hiding this comment.
Is this used somewhere? Same thing for its @types package
package.json
Outdated
| "yamljs": "^0.2.10" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/auth0-js": "^8.6.0", | ||
| "@types/bluebird": "^3.5.5", |
There was a problem hiding this comment.
Not directly, but knex's typings depend on this
There was a problem hiding this comment.
Since @types/knex depends on it, we don't need to add it to our dependencies.
There was a problem hiding this comment.
Yes, I thought it was missing from the @types/knex's package.json, but apparently when I ran npm rm @types/bluebird I should've run npm install afterwards. Removed now.
src/operations/operations-module.ts
Outdated
| if (existing === null) { | ||
| throw Boom.badGateway(); | ||
| } | ||
| const mappedExisting = (existing as any).map((item: any) => ({ |
There was a problem hiding this comment.
It seems that the reason you can't do existing.map() is that the Promise.all call above is incorrect. Shouldn't it be:
const [ expected, existing ] = await Promise.all([
this.getProjectDeploymentActivity(projectId),
this.activityModule.getProjectActivity(projectId),
]);?
Use util.promisify from Node Delete obsolete Route53Updater Remove obsolete aws-sdk typings and promisifications Compile to es2017 to take advantage of Node 8's native async/await support Include package-lock.json with the upgrade to npm 5
Upgrade circle to Node 8 as well
vsaarinen
force-pushed
the
update-packages-node
branch
from
ea3446a
to
30399fa
Compare
vsaarinen
approved these changes
Jun 9, 2017
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
util.promisifyfrom Node 8 and remove the self-coded implementationDelete obsolete Route53Updater
Remove obsolete aws-sdk typings and promisifications
Compile to es2017 to take advantage of Node 8's native async/await support
Include package-lock.json with the upgrade to npm 5
TODO