Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#767 Basic support for Spring JsonComparator #772

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

#767 Basic support for Spring JsonComparator #772

wants to merge 3 commits into from

Conversation

lukas-krecan
Copy link
Owner

No description provided.

@snicoll
Copy link

snicoll commented Jun 10, 2024 •
edited
Loading

Looks good!

As for

The integration API is pretty limited, so you are better off using JsonUnit directly.

JsonComparator is focused only on "is this matching the diff rules of that". For any sort of other assertions on JSON document, it's out of scope and is limited in that scope on purpose.

@lukas-krecan lukas-krecan force-pushed the spring branch 3 times, most recently from cbd76a3 to 1daaeba Compare June 16, 2024 18:11
@lukas-krecan
Copy link
Owner Author

It's part of v4 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukas-krecan @snicoll