WIP improve/fix component typing #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on a response on microsoft/TypeScript#17003 before finishing fixing the glamorous component factory typings. |
luke-john
force-pushed
the
task/fix-styled-function
branch
from
93433dd
to
b660f13
Compare
The usage of a union between Partials and Functions resulted in any functions passed to glamorous component factories being accepted by the type system. As part of fixing this I also renamed some types to align with the glamorous documentation. BREAKING CHANGE: Renamed types `HTMLGlamorousInterface` -> `HTMLComponentFactory`, `StyledFunction` -> `GlamorousComponentFactory`, `SVGGlamorousInterface` -> `SVGComponentFactory`. Also improved typesafety on them, so things that previously could have passed will now fail. 212
luke-john
force-pushed
the
task/fix-styled-function
branch
from
b660f13
to
f949dde
Compare
|
Just need to break this out into discrete commits now. All working as expected though on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.