Skip to content

Commit

Permalink
chore: fixup @aws-cdk/cdk-lib-alpha bundling (aws#26133)
Browse files Browse the repository at this point in the history
The bundle needs to contain the correct WASM embed at the right path in order to be able to load cleanly.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
RomainMuller authored and lukey-aleios committed Jun 30, 2023
1 parent 6beb68e commit 98f5b0e
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/cli-lib-alpha/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ npm-shrinkwrap.json

junit.xml


lib/*.wasm
8 changes: 4 additions & 4 deletions packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ THE SOFTWARE.

----------------

** acorn@8.8.2 - https://www.npmjs.com/package/acorn/v/8.8.2 | MIT
** acorn@8.9.0 - https://www.npmjs.com/package/acorn/v/8.9.0 | MIT
MIT License

Copyright (C) 2012-2022 by various contributors (see AUTHORS)
Expand Down Expand Up @@ -268,7 +268,7 @@ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES WITH RE

----------------

** aws-sdk@2.1379.0 - https://www.npmjs.com/package/aws-sdk/v/2.1379.0 | Apache-2.0
** aws-sdk@2.1401.0 - https://www.npmjs.com/package/aws-sdk/v/2.1401.0 | Apache-2.0
AWS SDK for JavaScript
Copyright 2012-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.

Expand Down Expand Up @@ -2951,7 +2951,7 @@ License, as follows:

----------------

** semver@7.5.1 - https://www.npmjs.com/package/semver/v/7.5.1 | ISC
** semver@7.5.2 - https://www.npmjs.com/package/semver/v/7.5.2 | ISC
The ISC License

Copyright (c) Isaac Z. Schlueter and Contributors
Expand Down Expand Up @@ -3402,7 +3402,7 @@ SOFTWARE.

----------------

** tslib@2.5.0 - https://www.npmjs.com/package/tslib/v/2.5.0 | 0BSD
** tslib@2.5.3 - https://www.npmjs.com/package/tslib/v/2.5.3 | 0BSD
Copyright (c) Microsoft Corporation.

Permission to use, copy, modify, and/or distribute this software for any
Expand Down
Empty file modified packages/@aws-cdk/cli-lib-alpha/generate.sh
100644 → 100755
Empty file.
5 changes: 3 additions & 2 deletions packages/@aws-cdk/cli-lib-alpha/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@
"cdk-build": {
"post": [
"yarn attribute",
"cp ../../../node_modules/vm2/lib/bridge.js ../../../node_modules/vm2/lib/setup-sandbox.js ./lib",
"yarn bundle"
"cp ../../../node_modules/vm2/lib/bridge.js ../../../node_modules/vm2/lib/setup-sandbox.js ../../aws-cdk/lib/vendor/noctilucent/index_bg.wasm ./lib/",
"yarn bundle",
"node ./lib/main.js >/dev/null 2>/dev/null </dev/null"
],
"env": {
"AWSLINT_BASE_CONSTRUCT": true
Expand Down

0 comments on commit 98f5b0e

Please sign in to comment.