feat: UniversalFactory #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contracts into feat/UniversalFactory
CJ42
reviewed
Apr 27, 2022
|
we need tests as well, do we have some? |
CJ42
reviewed
May 20, 2022
frozeman
approved these changes
May 20, 2022
CJ42
added a commit
that referenced
this pull request
Aug 14, 2023
…o-58-Refactor-function-_fallbackLSP17Extendable-to-enable-to-run-code-after-this-function-is-called_Jean fix: (C4 #139) refactor `_fallbackLSP17Extendable` function to enable to run code after it is called + prevent potential solc bug "storage write removal"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR introduce?
UniversalFactorythat should be used to deploy contracts deterministically.This contract gives the ability to deploy normal and EIP 1167 minimal proxy contracts, with the ability to specify if the contract should be initialized or not by passing the
initializeCallDatabytes.Deploying and initializing in one tx eliminate the risk of an initialize race (someone initializing before the right deployer).
If the UniversalFactory is deployed using nick's method on several chains, given the same salt and the same parameters, the contract created will have the same address on each chain.
This method is especially useful for UniversalProfiles, where you will have the ability to reproduce the same UniversalProfile at the same address on each chain you deploy to.