test: add extreme case tests

[b00ste]

What does this PR introduce?

🧪 Tests

Add tests:

• Make sure follow/unfollow cannot be reverted by return bomb attack
• Make sure follow/unfollow cannot be reverted by an infinite loop
• Make sure follow/unfollow cannot be reverted when contract self destructs on interface check

PR Checklist

• Wrote Tests
• Wrote & Generated Documentation (readme/natspec/dodoc)
• Ran npm run lint && npm run lint:solidity (solhint)
• Ran npm run format (prettier)
• Ran npm run build
• Ran npm run test

[skimaharvey]

LG

[JeneaVranceanu]

Whoami to approve? Looks good in the eyes of an amateur. Something new to learn 🙂

[JeneaVranceanu]

So.. a newbie question, how does it pass with this infinite loop running?
I see we get to

ILSP1UniversalReceiver(addr).universalReceiver(
                    _TYPEID_LSP26_FOLLOW,
                    abi.encodePacked(msg.sender)
                )

In the LSP26 contract and how does it not fail meaning the loop doesn't prevent transaction from failing letting the user to follow/unfollow?

[b00ste]

The external call to the contract that has the unviersalReceiver function with an infinite loop reverts, but due to the fact that we call that function using try/catch and we don't do anything in the catch, it does not revert while following or unfollowing someone. Usually you would catch the revert in the catch block and do what you need to from there. In our case we want to make sure we notify yet never revert.