-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NNCG to optimizers submodule #1661
Open
pratikrathore8
wants to merge
11
commits into
lululxvi:master
Choose a base branch
from
pratikrathore8:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+536
−5
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d0e22bb
Add NNCG to optimizers submodule
pratikrathore8 3afed9f
Update nys_newton_cg.py
pratikrathore8 081d5f6
Moved NNCG to pytorch folder
pratikrathore8 03a77a1
Minor formatting changes in NNCG
pratikrathore8 88d2f7e
Update nys_newton_cg.py
pratikrathore8 fff6a91
Fix Codacy issues
pratikrathore8 19490ea
Fix more Codacy issues
pratikrathore8 ec59a99
Added NNCG to config.py and optimizers.py
pratikrathore8 8995aad
Clean up NNCG integration in optimizers.py
pratikrathore8 1b13a08
Fixed import order in optimizers.py
pratikrathore8 2d63ba3
Made demo with NNCG and Burgers equation
pratikrathore8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? In the code of L-BFGS https://pytorch.org/docs/stable/_modules/torch/optim/lbfgs.html#LBFGS, this seems to be computed in
step()
byself._gather_flat_grad()
.