Pulling updates from masters #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are contradictory definitions of the term "test case", so prepare new users in Primer.md to avoid confusion.
fix small typo in comment
Use wider types to prevent unsigned overflow diagnostics
Update Primer.md
Correct some typos in a comment
Fix: Markdown in V1_7_Primer.md
update README.md with tiny-dnn
Fixed misspelling in assertion message.
Fix typo in gmock-actions.h
Missing periods
Fix punctuation in docs
…em::path as parameter google#521: Add is_same type trait
…em::path as parameter google#521: Add is_same type trait and prevent infinite loops for recursive containers
Use gender-neutral pronouns in comments and docs
…g issues in Windows
Updated README with C runtime dynamic/static linking issues in Windows info
Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…
Revert "Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…"
Workaround for Travis issue https://goo.gl/d5eV8o
ThreadLocal class needs to be have default visibility. Root cause is gtest uses typeinfo for the ThreadLocal class. The problem manifests When gtest/gmock are built as a shared library with libc++. When a class is used in typeinfo, it must have default visibility. There is an explanation about typeinfo and visibility here: https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/CppRuntimeEnv/Articles/SymbolVisibility.html When libc++ is used with gtest in shared library mode, any tests that are compiled with -fvisibility=hidden and exercise the macro EXPECT_CALL, it results in an abort like: [ FATAL ] /usr/include/gtest/internal/gtest-port.h:1394:: Condition typeid(*base) == typeid(Derived) failed. This is because the typeinfo for ThreadLocal class is not visible. Therefore, linker failed to match it to the shared library symbol, creating a new symbol instead. This fixes google#1207.
Update the CMakeLists.txt section in googletest README.md.
VS2015/2017 build fix and enable C++11 features (attempt number three)
…-indentation-warning Remove gcc 6 misleading indentations warnings
googletest: Add GTEST_API_ attribute to ThreadLocal class.
Enable CI for VS2017
…-1312 remove markdown stars (bold) from code examples
…ining colored output
Fix issue google#826 by treating MinGW as "non-Windows" when determining colored output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out 1.8 has bugs in it. Needed master to fix them.