Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix & enhance #19

Merged

Conversation

6543
Copy link

@6543 6543 commented Jun 15, 2021

some things I did ...

@6543
Copy link
Author

6543 commented Jun 15, 2021

wip because test is failing:
make test-sqlite#TestUserOrgs do still get org when it should not :/
generated sql:

--                                 get user             // filter by user id                                                          // make sure user set membership visible                                                              	// return only org's actor is allowed to see
-- TestUserOrgs: unrelated user should not get private org membership of privateMemberUsername
SELECT `id`, `...`, `lower_name`,  FROM `user` WHERE   `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=4) AND `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.is_public= true OR org_user.uid=5) AND (`user`.visibility IN (public,limited) OR `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=5)) ORDER BY `user`.`name` ASC; -- [4 true 5 public limited 5] - 81.88µs
SELECT count(*)                    FROM `user` WHERE   `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=?) AND `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.is_public= ?    OR org_user.uid=?) AND (`user`.visibility IN (?,?)            OR `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=?));                            -- [4 true 5 public limited 5] - 40.011µs
-- TestUserOrgs: not authenticated call also should hide org membership
SELECT `id`, `...`, `lower_name`,  FROM `user` WHERE   `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=4) AND `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.is_public= true)                   AND `user`.visibility=public ORDER BY `user`.`name` ASC; -- [4 true public] - 54.02µs
SELECT count(*)                    FROM `user` WHERE   `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=?) AND `user`.`id` IN (SELECT org_user.org_id FROM org_user WHERE org_user.is_public= ?)                      AND `user`.visibility=?;                                 -- [4 true public] - 26.57µs

@6543 6543 merged commit e4a1c93 into lunny:lunny/user_orgs_pagination Jun 20, 2021
@6543 6543 deleted the lunny/user_orgs_pagination branch June 20, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant