Migrate to lutaml-model from shale #7

ronaldtse · 2024-08-22T10:46:08Z

Fixes #6.

We still have the following failures inherited from #1 .

Failures:

  1) Ogc::Gml::Curve round-trips Curve-ArcByCenterPoint.xml
     Failure/Error:
       output = Ogc::Gml::Curve.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/curve_spec.rb:23:in `block (3 levels) in <top (required)>'

  2) Ogc::Gml::Curve round-trips Curve-ID_250.xml
     Failure/Error:
       output = Ogc::Gml::Curve.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/curve_spec.rb:23:in `block (3 levels) in <top (required)>'

  3) Ogc::Gml::Curve round-trips Curve-tripartite.xml
     Failure/Error:
       output = Ogc::Gml::Curve.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/curve_spec.rb:23:in `block (3 levels) in <top (required)>'

  4) Ogc::Gml::Polygon round-trips gmlring2.xml
     Failure/Error: expect(output).to be_equivalent_to(input)
     
       expected:
       <gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2"
                    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                    xsi:schemaLocation="http://www.opengis.net/gml/3.2
                                         http://schemas.opengis.net/gml/3.2.1/gml.xsd"
                    gml:id="ID1">
           <gml:exterior>
               <gml:Ring>
                   <gml:curveMember>
                       <gml:LineString srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2" gml:id="ID2">
                           <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
                       </gml:LineString>
                   </gml:curveMember>
               </gml:Ring>
           </gml:exterior>
       </gml:Polygon>
       got:
       <?xml version="1.0" encoding="utf-8"?>
       <gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2" gml:id="ID1">
         <gml:exterior>
           <gml:Ring>
             <gml:curveMember>
               <gml:LineString gml:id="ID2" srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2">
                 <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
               </gml:LineString>
             </gml:curveMember>
           </gml:Ring>
         </gml:exterior>
       </gml:Polygon>
       Diff:
       @@ -1,16 +1,13 @@
       -<gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2"
       -             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       -             xsi:schemaLocation="http://www.opengis.net/gml/3.2
       -                                  http://schemas.opengis.net/gml/3.2.1/gml.xsd"
       -             gml:id="ID1">
       -    <gml:exterior>
       -        <gml:Ring>
       -            <gml:curveMember>
       -                <gml:LineString srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2" gml:id="ID2">
       -                    <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
       -                </gml:LineString>
       -            </gml:curveMember>
       -        </gml:Ring>
       -    </gml:exterior>
       +<?xml version="1.0" encoding="utf-8"?>
       +<gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2" gml:id="ID1">
       +  <gml:exterior>
       +    <gml:Ring>
       +      <gml:curveMember>
       +        <gml:LineString gml:id="ID2" srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2">
       +          <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
       +        </gml:LineString>
       +      </gml:curveMember>
       +    </gml:Ring>
       +  </gml:exterior>
        </gml:Polygon>
       
     # ./spec/ogc/gml/polygon_spec.rb:28:in `block (3 levels) in <top (required)>'

  5) Ogc::Gml::Surface round-trips Surface-Curve-ID_250.xml
     Failure/Error:
       output = Ogc::Gml::Surface.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/surface_spec.rb:27:in `block (3 levels) in <top (required)>'

  6) Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurve.xml
     Failure/Error:
       output = Ogc::Gml::Surface.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/surface_spec.rb:27:in `block (3 levels) in <top (required)>'

  7) Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurveCW.xml
     Failure/Error:
       output = Ogc::Gml::Surface.from_xml(input).to_xml(
         pretty: true,
         declaration: true,
         encoding: "utf-8"
       )
     
     NoMethodError:
       undefined method `item_order' for an instance of String
     # ./spec/ogc/gml/surface_spec.rb:27:in `block (3 levels) in <top (required)>'

Finished in 53.25 seconds (files took 0.15704 seconds to load)
313 examples, 7 failures

Failed examples:

rspec ./spec/ogc/gml/curve_spec.rb[1:1] # Ogc::Gml::Curve round-trips Curve-ArcByCenterPoint.xml
rspec ./spec/ogc/gml/curve_spec.rb[1:3] # Ogc::Gml::Curve round-trips Curve-ID_250.xml
rspec ./spec/ogc/gml/curve_spec.rb[1:8] # Ogc::Gml::Curve round-trips Curve-tripartite.xml
rspec ./spec/ogc/gml/polygon_spec.rb[1:7] # Ogc::Gml::Polygon round-trips gmlring2.xml
rspec ./spec/ogc/gml/surface_spec.rb[1:1] # Ogc::Gml::Surface round-trips Surface-Curve-ID_250.xml
rspec ./spec/ogc/gml/surface_spec.rb[1:10] # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurve.xml
rspec ./spec/ogc/gml/surface_spec.rb[1:11] # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurveCW.xml

Interestingly, when using lutaml-model, these two specs were automatically fixed:

rspec ./spec/ogc/gml/multi_curve_spec.rb[1:1] # Ogc::Gml::MultiCurve round-trips MultiCurve-1.xml
rspec ./spec/ogc/gml/multi_curve_spec.rb[1:2] # Ogc::Gml::MultiCurve round-trips MultiCurve-2.xml

ronaldtse · 2024-08-22T10:48:24Z

Some of these spec failures are due to a bug in Lutaml::Model regarding item_order that exist in other migrations from Shale:

Migrate to Lutaml::Model genericode#13

However, this current gem does not utilize any custom methods. So this has to be a real bug.

HassanAkbar · 2024-08-27T11:19:14Z

@ronaldtse After merging PR lutaml/lutaml-model#62 for lutaml-model, there is no more crashing related to item_order. The tests that are failing were also failing on the main branch.

9 Failures on main branch

rspec './spec/ogc/gml/curve_spec.rb[1:1]' # Ogc::Gml::Curve round-trips Curve-ArcByCenterPoint.xml
rspec './spec/ogc/gml/curve_spec.rb[1:3]' # Ogc::Gml::Curve round-trips Curve-ID_250.xml
rspec './spec/ogc/gml/curve_spec.rb[1:8]' # Ogc::Gml::Curve round-trips Curve-tripartite.xml
rspec './spec/ogc/gml/multi_curve_spec.rb[1:1]' # Ogc::Gml::MultiCurve round-trips MultiCurve-1.xml
rspec './spec/ogc/gml/multi_curve_spec.rb[1:2]' # Ogc::Gml::MultiCurve round-trips MultiCurve-2.xml
rspec './spec/ogc/gml/polygon_spec.rb[1:7]' # Ogc::Gml::Polygon round-trips gmlring2.xml
rspec './spec/ogc/gml/surface_spec.rb[1:1]' # Ogc::Gml::Surface round-trips Surface-Curve-ID_250.xml
rspec './spec/ogc/gml/surface_spec.rb[1:10]' # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurve.xml
rspec './spec/ogc/gml/surface_spec.rb[1:11]' # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurveCW.xml

and 7 Failures on current branch

rspec './spec/ogc/gml/curve_spec.rb[1:1]' # Ogc::Gml::Curve round-trips Curve-ArcByCenterPoint.xml
rspec './spec/ogc/gml/curve_spec.rb[1:3]' # Ogc::Gml::Curve round-trips Curve-ID_250.xml
rspec './spec/ogc/gml/curve_spec.rb[1:8]' # Ogc::Gml::Curve round-trips Curve-tripartite.xml
rspec './spec/ogc/gml/polygon_spec.rb[1:7]' # Ogc::Gml::Polygon round-trips gmlring2.xml
rspec './spec/ogc/gml/surface_spec.rb[1:1]' # Ogc::Gml::Surface round-trips Surface-Curve-ID_250.xml
rspec './spec/ogc/gml/surface_spec.rb[1:10]' # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurve.xml
rspec './spec/ogc/gml/surface_spec.rb[1:11]' # Ogc::Gml::Surface round-trips Surface-PolygonPatch-ExteriorCurveCW.xml

ronaldtse · 2024-08-29T12:34:54Z

Only one failure left!!

  1) Ogc::Gml::Polygon round-trips gmlring2.xml
     Failure/Error: expect(output).to be_equivalent_to(input)
     
       expected:
       <gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2"
                    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                    xsi:schemaLocation="http://www.opengis.net/gml/3.2
                                         http://schemas.opengis.net/gml/3.2.1/gml.xsd"
                    gml:id="ID1">
           <gml:exterior>
               <gml:Ring>
                   <gml:curveMember>
                       <gml:LineString srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2" gml:id="ID2">
                           <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
                       </gml:LineString>
                   </gml:curveMember>
               </gml:Ring>
           </gml:exterior>
       </gml:Polygon>
       got:
       <?xml version="1.0" encoding="utf-8"?>
       <gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2" gml:id="ID1">
         <gml:exterior>
           <gml:Ring>
             <gml:curveMember>
               <gml:LineString gml:id="ID2" srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2">
                 <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
               </gml:LineString>
             </gml:curveMember>
           </gml:Ring>
         </gml:exterior>
       </gml:Polygon>
       Diff:
       @@ -1,16 +1,13 @@
       -<gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2"
       -             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       -             xsi:schemaLocation="http://www.opengis.net/gml/3.2
       -                                  http://schemas.opengis.net/gml/3.2.1/gml.xsd"
       -             gml:id="ID1">
       -    <gml:exterior>
       -        <gml:Ring>
       -            <gml:curveMember>
       -                <gml:LineString srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2" gml:id="ID2">
       -                    <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
       -                </gml:LineString>
       -            </gml:curveMember>
       -        </gml:Ring>
       -    </gml:exterior>
       +<?xml version="1.0" encoding="utf-8"?>
       +<gml:Polygon xmlns:gml="http://www.opengis.net/gml/3.2" gml:id="ID1">
       +  <gml:exterior>
       +    <gml:Ring>
       +      <gml:curveMember>
       +        <gml:LineString gml:id="ID2" srsName="http://www.opengis.net/gml/srs/epsg.xml#4326" srsDimension="2">
       +          <gml:posList>0 0 0 1 1 1 1 0 0 0</gml:posList>
       +        </gml:LineString>
       +      </gml:curveMember>
       +    </gml:Ring>
       +  </gml:exterior>
        </gml:Polygon>
       
     # ./spec/ogc/gml/polygon_spec.rb:28:in `block (3 levels) in <top (required)>'

Finished in 49.38 seconds (files took 0.13208 seconds to load)
313 examples, 1 failure

ronaldtse · 2024-08-30T11:59:56Z

The only remaining diff is:

       -             xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       -             xsi:schemaLocation="http://www.opengis.net/gml/3.2
       -                                  http://schemas.opengis.net/gml/3.2.1/gml.xsd"

ronaldtse added 6 commits August 22, 2024 17:20

chore: remove file names from files

bac7b44

chore: move ets-gml32 to spec/fixtures

d2a2a58

chore: display only filename in dictionary specs

6e504e2

feat: migrate to lutaml-model, fixes #6

e2eda64

feat: update README

fe3b0dc

chore: rubocop

3d6ee33

ronaldtse mentioned this pull request Aug 22, 2024

(URGENT) undefined method `item_order' for an instance of String lutaml/lutaml-model#59

Closed

ronaldtse assigned HassanAkbar Aug 22, 2024

ronaldtse added the bug Something isn't working label Aug 22, 2024

fix: unit of measure subclasses

0a28375

ronaldtse merged commit 286c9bc into main Aug 30, 2024
2 of 15 checks passed

ronaldtse deleted the rt-migrate-to-lutaml-model branch August 30, 2024 12:00

ronaldtse mentioned this pull request Aug 30, 2024

Fix remaining round-trip failure due to xsi:schemaLocation and xsi namespace #9

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to lutaml-model from shale #7

Migrate to lutaml-model from shale #7

ronaldtse commented Aug 22, 2024

ronaldtse commented Aug 22, 2024

HassanAkbar commented Aug 27, 2024

ronaldtse commented Aug 29, 2024

ronaldtse commented Aug 30, 2024

Migrate to lutaml-model from shale #7

Migrate to lutaml-model from shale #7

Conversation

ronaldtse commented Aug 22, 2024

ronaldtse commented Aug 22, 2024

HassanAkbar commented Aug 27, 2024

ronaldtse commented Aug 29, 2024

ronaldtse commented Aug 30, 2024