add TrackletConverter + Example Publisher #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninoweg
changed the title
saching13
reviewed
May 15, 2023
depthai_ros_msgs/msg/Tracklet.msg
Outdated
| int32 status | ||
|
|
||
| # Image detection that is tracked. | ||
| ImgDetection srcImgDetection |
There was a problem hiding this comment.
Can you replace this with a standard message here
There was a problem hiding this comment.
I replaced the custom ImgDetecion msg using vision_msgs/ObjectHypothesis and vision_msgs/BoundingBox2D
|
I had to update the TrackerConverter because denormalization was still missing. Was I right to assume that for denormalizing tracklets.roi I need to use the inputTrackerFrame and for tracklets.srcImgDetection the inputDetectionFrame of the ObjectTracker? |
|
LGTM. Can you add a simple python script in scripts which overlays the bounding box and make a small video which shows it's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add Tracklet msg, TrackletConverter and example Object Tracker Publisher