several improvements #5
Conversation
alexeibs
commented
Jul 28, 2016
alexeibs
commented
- add support for 8-bit characters ('xx)
- fix issue with generating empty HTML files in some cases
- remove possibly redundant std::logic_error which causes an error on some files
| for (cell_def=(*row)->CellDefs->begin(), cell=(*row)->Cells.begin(); | ||
| cell!=(*row)->Cells.end(); | ||
| cell!=(*row)->Cells.end() && cell_def!=(*row)->CellDefs->end(); |
There was a problem hiding this comment.
Have you seen any cases when we had this error on a real rtf file?
There was a problem hiding this comment.
Yes, I have. I converted RTF specifaction (from here: https://www.microsoft.com/en-us/download/details.aspx?id=10725) to RTF format using LibreOffice Writer 5.1.4.2. Then I tried to make an HTML file from it using rtf2html. And I got that error
There was a problem hiding this comment.
Ok, so which list was longer? And what was in its 'extra' elements?
There was a problem hiding this comment.
I would like to know before I pull this, as the situation itself looks very strange.
|
Hi, guys. |
|
rebase needed, probably due to #8, which added unicode support |
