Issue929 #1
Draft
Issue929 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f062086.
…s, passed log_k_eq_constraint equilibrium_constraint for both solubility product and common eqbm mole_frac_phase_comp
… temprature Enthalpy unit corrected
This reverts commit f062086.
…s, passed log_k_eq_constraint equilibrium_constraint for both solubility product and common eqbm mole_frac_phase_comp
… temprature Enthalpy unit corrected
…ed solubility_product
… down as an additional variable Use smooth_max from idaes utility and other minor improvements
Fix Issue929 tests
* add * delete redundant files * Relax bounds of dP_dx
Fix linux test failures
…weep API (watertap-org#1093) * Update parameter sweep standalone function args and docstring * Updated monte carlo flowsheet example to use new non-deprecated parameter sweep api * Update documentation to reflect new api for parameter sweep * Remove unnecessary solve() from monte carlo example * Update watertap/examples/flowsheets/RO_with_energy_recovery/monte_carlo_sampling_RO_ERD.py Co-authored-by: Kinshuk Panda <kinshukpanda@gmail.com> * Lint fix: removed unused import --------- Co-authored-by: Sam Helman <shelman@nrel.gov> Co-authored-by: Kinshuk Panda <kinshukpanda@gmail.com>
Fix pylint and docs
* add rectifier cost to ed * modify fs test to reflect changes * correct capitcal cost * correct capitcal cost * Adapt testing * redo ED costing profile * format * fix neglected tests * costing itemization * address failure in experimental macos * fix a warning of implicit replacement of costing component * delete commented codes * delete commented codes * Changed costing to safer implementaton Avoids deleting capital cost and captial cost constraints, simply checks if rectfier costing exists. * Fixed typo. * Update test_electrodialysis_1D.py * fix a costing err and update tests, update performance report of ED --------- Co-authored-by: Keith Beattie <ksbeattie@lbl.gov> Co-authored-by: avdudchenko <33663878+avdudchenko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: