Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonizes naming pattern of pre-built binaries and unlocks latest permalink #1464

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

axel-kah
Copy link
Contributor

@axel-kah axel-kah commented Jul 6, 2024

This closes #1463

@mre
Copy link
Member

mre commented Jul 7, 2024

Interesting.

We probably also need to update the Docker images here and here as well as create a PR for the lychee-action here.

The Dockerfiles can be updated in the same PR.

@axel-kah
Copy link
Contributor Author

axel-kah commented Jul 7, 2024

@axel-kah
Copy link
Contributor Author

axel-kah commented Jul 7, 2024

The test fails seem to be unrelated to my changes. Their implementation contains remarks about flakyness. Maybe increasing the number of re-tries or adding a delay in between would help to reduce the ci-noise.

@mre mre merged commit d0c5af9 into lycheeverse:master Aug 6, 2024
7 checks passed
@mre
Copy link
Member

mre commented Aug 6, 2024

Thanks @axel-kah! The code looks fine. I didn't find a great way to test it, but we'll give it a shot with the next release. 👍

@axel-kah
Copy link
Contributor Author

axel-kah commented Aug 6, 2024

Sweet! Any idea when that will be (ballpark)?

dscho added a commit to dscho/lychee-action that referenced this pull request Aug 12, 2024
The name of the `.tar` file is repeated multiple times, verbatim. This
not only violates the Don't Repeat Yourself (DRY) principle, it also
makes it easier to miss an instance when the file name changes (as it
did with lycheeverse/lychee#1464).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/lychee-action that referenced this pull request Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them
start with `lychee-<version>-`. This is no longer the case as of
lycheeverse/lychee#1464, though, breaking the
`lychee-action`.

Since we need to allow using older versions, still, we are now stuck
with a really ugly `case` construct, but this is still far better than
having a broken GitHub Action.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/lychee-action that referenced this pull request Aug 12, 2024
The name of the `.tar` file is repeated multiple times, verbatim. This
not only violates the Don't Repeat Yourself (DRY) principle, it also
makes it easier to miss an instance when the file name changes (as it
did with lycheeverse/lychee#1464).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/lychee-action that referenced this pull request Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them
start with `lychee-<version>-`. This is no longer the case as of
lycheeverse/lychee#1464, though, breaking the
`lychee-action`.

Since we need to allow using older versions, still, we are now stuck
with a really ugly `case` construct, but this is still far better than
having a broken GitHub Action.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/lychee-action that referenced this pull request Aug 12, 2024
Until version 0.15.1, the naming scheme of the release assets let them
start with `lychee-<version>-`. This is no longer the case as of
lycheeverse/lychee#1464, though, breaking the
`lychee-action`.

Since we need to allow using older versions, still, we are now stuck
with a really ugly `case` construct, but this is still far better than
having a broken GitHub Action.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@mre
Copy link
Member

mre commented Aug 20, 2024

We got some issues with the change. Follow lycheeverse/lychee-action#232 and lycheeverse/lychee-action#234 for updates.

mre pushed a commit to lycheeverse/lychee-action that referenced this pull request Aug 20, 2024
Work around new naming scheme

Until version 0.15.1, the naming scheme of the release assets let them
start with `lychee-<version>-`. This is no longer the case as of
lycheeverse/lychee#1464, though, breaking the
`lychee-action`.

Since we need to allow using older versions, still, we are now stuck
with a really ugly `case` construct, but this is still far better than
having a broken GitHub Action.

The name of the `.tar` file is repeated multiple times, verbatim. This
not only violates the Don't Repeat Yourself (DRY) principle, it also
makes it easier to miss an instance when the file name changes (as it
did with lycheeverse/lychee#1464).
DRY up the lengthy `.tar` file name.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: inconsistent naming of gh release assets
2 participants