Skip to content

Commit

Permalink
[portsorch] Fix inconsistent return value in bindAclTable (sonic-net#791
Browse files Browse the repository at this point in the history
)

Signed-off-by: yorke <yorke.yuan@asterfusion.com>
  • Loading branch information
lorchid authored and lguohan committed Mar 21, 2019
1 parent 5984e3a commit ea54825
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions orchagent/portsorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
{
SWSS_LOG_ERROR("Failed to bind port %s to ACL table group %lx, rv:%d",
port.m_alias.c_str(), group_oid, status);
return status;
return false;
}
break;
}
Expand All @@ -842,7 +842,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
{
SWSS_LOG_ERROR("Failed to bind LAG %s to ACL table group %lx, rv:%d",
port.m_alias.c_str(), group_oid, status);
return status;
return false;
}
break;
}
Expand All @@ -858,14 +858,14 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
{
SWSS_LOG_ERROR("Failed to bind VLAN %s to ACL table group %lx, rv:%d",
port.m_alias.c_str(), group_oid, status);
return status;
return false;
}
break;
}
default:
{
SWSS_LOG_ERROR("Failed to bind %s port with type %d", port.m_alias.c_str(), port.m_type);
return SAI_STATUS_FAILURE;
return false;
}
}

Expand Down

0 comments on commit ea54825

Please sign in to comment.