Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to build C API with clang #88

Closed
xq114 opened this issue Jul 5, 2024 · 1 comment
Closed

Fail to build C API with clang #88

xq114 opened this issue Jul 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@xq114
Copy link

xq114 commented Jul 5, 2024

src/bvh/v2/bvh.h:173:21: error: no member named 'make_tuple' in namespace 'std'
  173 |         return std::make_tuple(
      |                ~~~~~^
src/bvh/v2/c_api/bvh_impl.h:31:32: error: missing 'typename' prior to dependent type name 'bvh::v2::DefaultBuilder<bvh::v2::Node<T, Dim>>::Quality'
            return static_cast<bvh::v2::DefaultBuilder<bvh::v2::Node<T, Dim>>::Quality>(quality);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                               typename 

Seems adding #include <tuple> and typename would help

@madmann91
Copy link
Owner

Thank you for the bug report. Strangely enough, I could not reproduce this issue on my local machine, nor on GitHub's CI. I have nevertheless added the corresponding #include and typename in commit 77a08ca. If that does not solve the problem, please re-open this issue.

@madmann91 madmann91 added the bug Something isn't working label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants